Model.create() does not have the option to set only `overwrite` about nestjs-dynamoose HOT 6 CLOSED

@MickL Please add return: "document" like following

catModel.create(cat, { overwrite: true, return: "document" } );

from nestjs-dynamoose.

Why? That is not a required value by Dynamoose, just in your interfaces 😕

Same problem for:

Model.get(
            {id},
            {
                attributes: ['something'],
            },
);

Also wants to have return:

Property 'return' is missing in type '{ attributes: string[]; }' but required in type 'ModelGetSettings'.

from nestjs-dynamoose.

@MickL please check this out from dynamoose

https://github.com/dynamoose/dynamoose/blob/27326613aa391f0223ef05d2e95c21e33d630a27/lib/Model/index.ts#L828

which is exactly the same as here :

  get( key: Key, settings: ModelGetSettings & { return: 'document' }): Promise<Data>;

The reason is that it is required by the Typescript type inference to correctly choose the right interface, so you will face the same problem if you use the type from dynamoose too.

from nestjs-dynamoose.

Hm then maybe that interface is wrong? I am not using return: 'document' with @ts-ignore and it works as expected. I dont think it is or should be required.

from nestjs-dynamoose.

@MickL yes it shouldn't be required, however it may due to some technical difficulty, you may ask @fishcharlie about this :)

from nestjs-dynamoose.

I opened an issue: dynamoose/dynamoose#912

from nestjs-dynamoose.