The time allocated for FrameManager to initialize is not enough (1 second) about puppeteer-sharp HOT 8 CLOSED

@AleksandrsJakovlevsVisma Are you willing to test some custom build to confirm the fix?

from puppeteer-sharp.

@kblok Sorry for the delay, I was on vacation.

Yes, I don't mind trying a custom build

from puppeteer-sharp.

@AleksandrsJakovlevsVisma I'm exposing the TaskHelper timeout here. Can you see if increasing the timeout there helps?

That's an static class that will affect the entire library.

from puppeteer-sharp.

@kblok I did the following:

1. Downloaded that branch as zip and referenced the csproj in my proj
2. I also did one additional change seen below
   
3. In my code I am setting DefaultTimeout to 30 secs
4. During testing I am no longer seeing TargetClosedException, but now I am getting 504 gate-way timeouts from the API that is using Puppeteer

from puppeteer-sharp.

@kblok I did the following:

2. I also did one additional change seen below

Good catch

4. During testing I am no longer seeing TargetClosedException, but now I am getting 504 gate-way timeouts from the API that is using Puppeteer

That would be something on your side right?

from puppeteer-sharp.

@kblok

Thank you for helping out with this one.

It is the problem on our side, yes. The PDF conversion on average takes 6 seconds, but the request times out after a minute. 200 requests with a max count of simultaneously opened pages = 10 is not enough to make sure each of 200 finishes in a minute. Do you have any advice on how to speed up a simple HTML to PDF conversion? Perhaps there are some magic LaunchOptions args?

In any case, can we expect the configurable default timeout released in the near future?

from puppeteer-sharp.

@kblok

Thank you for helping out with this one.

It is the problem on our side, yes. The PDF conversion on average takes 6 seconds, but the request times out after a minute. 200 requests with a max count of simultaneously opened pages = 10 is not enough to make sure each of 200 finishes in a minute. Do you have any advice on how to speed up a simple HTML to PDF conversion? Perhaps there are some magic LaunchOptions args?

PDF generate is quite resource intensive. If you look at the code, most of the time is on the browser side.

In any case, can we expect the configurable default timeout released in the near future?

I can ship it today :)

from puppeteer-sharp.

@kblok

I can ship it today :)

Nice, we will look forward to it, whenever you'll have the time :)

from puppeteer-sharp.