Comments (5)
Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):
Oh that is exciting, its great to hear where the library is being used. I drove a Model S for the first time on Sunday and loved it.
from python-can.
Original comment by Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev):
Very belatedly - thanks! This was my first open source contribution, so I appreciate your patience. FWIW I'm hoping to use your library for some automated testing at Tesla, should be pretty cool.
from python-can.
Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):
Sure, you should be able to do the fork + PR reasonably easily but if you run into trouble post back here and I'll give you access to this repository. As with github though, usually you would make a few pull requests before given direct access.
Bitbucket has a nice tutorial: https://confluence.atlassian.com/display/BITBUCKET/Fork+a+Repo,+Compare+Code,+and+Create+a+Pull+Request
from python-can.
Original comment by Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev):
Brian, gladly - I'm not having success pushing from SourceTree though. Could you give me the necessary access to start a new branch and pull request? Or link me to an explanation of the workflow I should use (I'm new to using Bitbucket :)).
from python-can.
Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):
Would you like to create a pull request for this change Jack? I don't have access to PCAN hardware so hopefully someone else can test/review.
from python-can.
Related Issues (20)
- Typo in Error Handling Code: 'sane' should be 'same'
- Adding support for popular automotive industry interfaces such as J2534 VCI to the interface
- Add `flush_rx_buffer` to `BusABC`
- Multiple CAN message thread sending the cycle time is not reliable HOT 2
- Add CAN Trove classifier HOT 2
- Ability to send_periodic() a group of messages with different arbitration ids and a variable rate period HOT 1
- Recive manipulate and send HOT 2
- viewer with CAN-FD, print packets with variable DLC but same ID in different lines HOT 1
- can.detect_available_configs() returns neousys interface when not connected
- In canfd, when data length > 8, dlc != len(data) in Message._check will cause an error HOT 4
- Segmentation fault when calling ics.close_device() HOT 15
- Detect available configs fails for vector on Windows 11 HOT 2
- IXXAT and isCAN dongle can't handle unit not responding
- slcan interface needs some time-tweaking (Possible solution provided)
- gs_usb does not support set_bitrate() for some Candlelight devices HOT 1
- Mac OS: Deleting two separate PCAN buses simultaneously causes hard python script exit (assertion failed)
- Not able to send CANFD message in "pcan" interface HOT 2
- BLFWriter append messages to an existing log file does not take effect HOT 2
- Could not import vxlapi: function 'xlCanReceive' not found
- SYSTEC: sending remote frame does not respect dlc value
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-can.