Problematic JPEG image about twelvemonkeys HOT 12 CLOSED

Did not work for me too, here is an exception if it helps

java.lang.NullPointerException
at com.twelvemonkeys.imageio.plugins.jpeg.JPEGImageReader.getSourceCSType(Unknown Source)
at com.twelvemonkeys.imageio.plugins.jpeg.JPEGImageReader.read(Unknown Source)
at javax.imageio.ImageIO.read(ImageIO.java:1448)
at javax.imageio.ImageIO.read(ImageIO.java:1308)

from twelvemonkeys.

Hmmm..

NullPointerExceptions are never good. I'll look into it, as soon as possible.

As always, thanks for reporting and providing test a case!

.k

from twelvemonkeys.

Hi Marcus,

Less time in my day job these days to fix issues like this.. But I finally found some time today, and identified the problem. There seems to a lot of trash/padding 0x00s between two JPEG markers, apparently for no good reason. Don't think this is allowed according to spec, but seems to be common (google for "Corrupt JPEG data: extraneous bytes before marker"). I can probably mask these bytes out of the stream, and handle in some way, but I need to work out a good strategy first... Stay tuned. :-)

Harald K

from twelvemonkeys.

Hi Harald, thanks for your effort so far. I just wonder how many different JPEG spec violations are out there that must be considered... seems like an unsolvable task to me :-(

from twelvemonkeys.

Well..

If I only knew upfront all the different spec violations there was...
As long as handling one type of violation doesn't rule out reading other images (which is still the case), I think we're good. :-)

I made the reader able to read your image. I just want to provide better warning feedback to the listeners and clean things up a little before checking in.

Side note: The (Exif?) thumbnail seems broken (correct data bout 2/3 down, then nothing). Is this the case in other software too?

Best regards,

Harald K

from twelvemonkeys.

Just pushed a fix.

from twelvemonkeys.

Thanks! ...and yes, you're right. It seems MacOS uses the damaged embedded thumbnail while rendering the file (preview) icon.

from twelvemonkeys.

Cool. I'm home free then. ;-)

from twelvemonkeys.

Thanks for this fix and the great job you have done with this library!

from twelvemonkeys.

Has this fix been released? I see a similar issue with 3.0 but didn't check 3.0.2 yet. Will do so now...

from twelvemonkeys.

Alright... I got a NPE at

    com.twelvemonkeys.imageio.plugins.jpeg.JPEGImageReader.getSourceCSType(Unknown Source)
    com.twelvemonkeys.imageio.plugins.jpeg.JPEGImageReader.read(Unknown Source)
    javax.imageio.ImageReader.read(ImageReader.java:939)

But the reason for this was that the image with a jpeg extension was actually a png. Changing the extension the png fixed the problem. Should I file a new issue for that?

from twelvemonkeys.

@huxi My plugins does not do file format recognition by looking at file extensions, so I'm not sure how that happened... But yes, file an issue, with the code you are using and attach the image you used, and I'll look into it.

The original issue has been fixed, at least both 3.0.1 and 3.0.2 has no problems reading the linked image.

Harald K

from twelvemonkeys.