`lpc845-test-assistant` doesn't build with latest `lpc8xx-hal` commit about embedded-test-stand HOT 3 CLOSED

Yes, that's definitely lpc-rs/lpc8xx-hal#298. I mean, I didn't try to break the build here specifically, but I knew this was a breaking change, so yes, it's on purpose :-)

Now that I'm looking at it again, this does expose some problems with that pull request though:

1. There doesn't seem to be a way to convert Ticks to u32. There should definitely be an Into<u32> implementation, and maybe an inherent method that does the same (Ticks::value?).
2. That Channel::value and Channel::reload_value return u32 and not Tick is questionable. That deserves another look.

I've made a note to look into this, but it's unlikely I'll get to it before January. Feel free to submit a pull request upstream.

from embedded-test-stand.

Okay, cool! I've added a similar quick fix to my codebase, should be convertible to a PR :) I'm wondering, would adding Into<Nanoseconds>, Into<Milliseconds>.. etc be useful too while we're at it?

from embedded-test-stand.

Okay, cool! I've added a similar quick fix to my codebase, should be convertible to a PR :) I'm wondering, would adding Into<Nanoseconds>, Into<Milliseconds>.. etc be useful too while we're at it?

Good idea, that sounds useful.

from embedded-test-stand.