Git Product home page Git Product logo

Comments (1)

jbennink avatar jbennink commented on July 21, 2024

It looks like ToString() returns a cronexpression with seconds, hence the extra 0 in front. It looks like internally the fact that seconds were not included in the cronexpression parsed is not stored hence upon returning the ToString() it is not possible to differentiate between no seconds supplied and 0 seconds, which results in the 0 in the result.

P.S. The current implementation is not wrong, it might however be unexpected.
P.P.S. It is a different matter whether you want the exact same syntax back */5 instead of 0,5,10,15,20,25,30,35,40,45,50,55 which is again a decision, both express the same cronexpression.
P.P.P.S. Optimizing for ToString() speed is again, another matter and a separate thing from what should be returned from ToString() Since the implementation already does some bit-shift magic and explicitly mention storage bit sizes I guess someone might object to any bytes of additional memory consumed for optimizing ToString()

@odinserj If replies like this are not appreciated please say so. I was not trying to give opinionated answers or comments

from cronos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.