Use md5 hash as disk cache filename if key is too long about hanekeswift HOT 10 CLOSED

This is turning out to be really difficult. The implementation is done, but with a nasty hack involving module maps to include CommonCrypto, which is what I use to calculate the MD5.

I'm considering either waiting until Swift has a MD5 function, or using a simpler hashing method.

from hanekeswift.

Maybe Fowler–Noll–Vo.

from hanekeswift.

Maybe https://gist.github.com/pietbrauer/2205b5c9986a9d886b00

from hanekeswift.

Yeah, something like that is what I used initially. The problem is using the C library CommonCrypto in a Swift framework.

FNV can be implemented without external dependencies.

from hanekeswift.

Oh, I didn't realize he's using CommonCrypto there, sorry. Yeah, then FNV could be the solution 😄

from hanekeswift.

Work in progress in this branch.

I'm freeing this issue for now. Might return to it later (Beta 7?).

from hanekeswift.

What's the status on this? Probably we could check this out https://github.com/krzyzanowskim/CryptoSwift/blob/master/CryptoSwift/MD5.swift

from hanekeswift.

I was waiting for Apple to add the CommonCrypto module, but we can also use this (assuming it actually works). Nice find!

from hanekeswift.

murmur hash might be a good solution for this. https://github.com/jwerle/murmurhash.c is an example of this and there are 64 bit versions of this as well, all of them CommonCrypto free

from hanekeswift.

Thanks @madninja. I decided to use CryptoSwift as I'm more familiar with MD5.

from hanekeswift.