Multiple file watchers didn't work? (second watches outside of /Scripts folder) about fastscriptreload HOT 9 OPEN

I have multiple watchers set, not tested yet if it faills, I'll keep an eye on it.

from fastscriptreload.

I'd start looking in FastScriptReload.Editor.FastScriptReloadManager.OnWatchedFileChange and see if file changes are correctly calling that method.

Probably just by making some islolated changes to file-watcher 1, then 2 then 3 and see if method is called.

Ideally it'd be which would mean issue is somewhere in that method when it tries to mark files for hot-reload.

If it's not called then issue will be down to either

1. File Watcher initialization which is done in FastScriptReload.Editor.FastScriptReloadManager.StartWatchingDirectoryAndSubdirectories - finding bug there should be fairly straight forward, if it's not setting properly
2. Some issue with FileWatcher - it actually has quite a few issues (Unity implementation) - so wouldn't be that surprised if it's down to that.

Would be good to hear what you have found, thanks!

from fastscriptreload.

I think in general bugged in Unity implementation. I've seen some odd issues with that for a while now. On some editor versions file watcher will just give you file-name without actual part (even relative to project root).

Probably only real solution is to implement different file-watching mechanism

from fastscriptreload.

Ii was working but now it isn't anymore, I have 3 file watchers specified, only the files watch by the 1st one are hot reloaded. Pretty sure it was working prior to unknown 😄

You could indicate me what I should check for

from fastscriptreload.

FastScriptReload.Editor.FastScriptReloadManager.OnWatchedFileChange is indeed not called. And the file watcher seems fine after initialization.
So it seems to lie in the file watcher itself.

from fastscriptreload.

Could be this :
dotnet/runtime#17626
I will try the solution and let you know
NotifyFilter = NotifyFilters.LastWrite | NotifyFilters.FileName,

from fastscriptreload.

Could be this : dotnet/runtime#17626 I will try the solution and let you know NotifyFilter = NotifyFilters.LastWrite | NotifyFilters.FileName,

No, not working !

from fastscriptreload.

Does nothing more :

 fileWatcher.NotifyFilter = NotifyFilters.Attributes
                                       | NotifyFilters.CreationTime
                                       | NotifyFilters.DirectoryName
                                       | NotifyFilters.FileName
                                       | NotifyFilters.LastAccess
                                       | NotifyFilters.LastWrite
                                       | NotifyFilters.Security
                                       | NotifyFilters.Size;
            fileWatcher.Changed += OnWatchedFileChange;
            fileWatcher.Created += OnWatchedFileChange;
            fileWatcher.Deleted += OnWatchedFileChange;
            fileWatcher.Renamed += OnWatchedFileChange;
            fileWatcher.Error += (object sender, ErrorEventArgs e) => Debug.LogError(e.GetException());

from fastscriptreload.

It's terribly weird.

1. <Application.dataPath>/3rdParties/GPUInstancer alone works
2. <Application.dataPath>/Scripts alone works.
3. 1 + 2 only triggers files in 2.
4. 2 + 1 only triggers files in 2
5. <Application.dataPath> alone is too slow on recompile and enter play mode.

What is going on !?

My random guess : internally the filewatcher impl might order the path and have some savy mechanism to avoid concurrent watching and which is bugged in this case ?

from fastscriptreload.