Git Product home page Git Product logo

Comments (6)

adrianszymanski89 avatar adrianszymanski89 commented on September 26, 2024

Hi @gtoniolo

Thank you for contacting us. That's correct, and it was changed in v. 13.0 in this PR: #10231. You can read the whole reason for this change there.

from handsontable.

gtoniolo avatar gtoniolo commented on September 26, 2024

I'm not questioning the order of operations clearly stated in the breaking change. I'm saying that the method with two arguments doesn't work, whereas the one with four does.

And this is not indicated in the documentation, or at least I can't find it.

Perhaps I was wrong in invoking it with two arguments even before.

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on September 26, 2024

Hi @gtoniolo

I checked that, and I'm not sure if I can reproduce the issue. In both versions, it seems to work the same:

from handsontable.

gtoniolo avatar gtoniolo commented on September 26, 2024

https://jsfiddle.net/gtoniolo/he4qmrcn/1/

Debugging handsontable source code the setDataAtCell with two args is calling the 4 args and the '2args' is going in 'col' argument.

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on September 26, 2024

Hi @gtoniolo

Thank you for the example. Let me discuss it with the development team and get back to you.

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on September 26, 2024

Hi @gtoniolo

I got new info on your issue. Our developers confirmed that defining 2nd and 3rd arguments as undefined to pass the custom source is the correct way.

Thank you for pointing that out, as we also discovered that there are some inconsistencies within the tests and documentation for the setDataAtCell hook.

from handsontable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.