Crashing on changing orientation while UISearchController is active about hgplaceholders HOT 8 CLOSED

@Idomo Thanks for reporting, I will look at it asap, If you find a fix don't hesitate to create a PR, thanks

from hgplaceholders.

@HamzaGhazouani
After more checking I'v noticed it's happening only when changing the orientation while the keyboard is active, otherwise it won't crash.

One more thing I'v noticed for is that the tableView(_tableView:, heightForRowAt indexPath:) in PlaceholderDataSourceDelegate is getting called a lot of times (some times it was about 20 times) although only one operation (like changing orientation or setting searchController to be active) has been performed.

Hope you'll be able to find solution for this, 'cause it's very critical issue.
Thanks,
Ido.

from hgplaceholders.

@HamzaGhazouani I wish I would be able to fix this, my app is on the App Store for about a month and I don’t want users to stop using it only because of this crash.
Hope you’ll be able to fix this ASAP.

from hgplaceholders.

HI @HamzaGhazouani and @jamchen @monkeywithacupcake @Brusnikin (May you'll be able to resolve this),
There is any progress with this issue? it's kinda old and pretty big one.
So far no one that using my app has been reported to me about it, but I don't want to wait for someone to do so.

from hgplaceholders.

@HamzaGhazouani I'd like to release an update with bug fixes to my app, this is pretty much in my top priority right now, so please, help me with this one.
*I can reproduce this also on iOS 13 (with real device).

from hgplaceholders.

I cannot reproduce this error.

from hgplaceholders.

I cannot reproduce this error.

On which iOS version and device (simulator/real and model)?

from hgplaceholders.

@HamzaGhazouani Finally, after a 3.5 years, the issue has been solved!
You may merge #71 (and the rest of the PRs that seems to be forgotten) and release some update.

from hgplaceholders.