Git Product home page Git Product logo

Comments (19)

ericcj avatar ericcj commented on September 4, 2024 9

I inquired about MWS for amazon.co.uk and they said "We understand that you are requesting to get access to the MWS API in the UK. Please note that we are no longer accepting registration applications for MWS." so at least there we're already forced to use SP-API. Between the oauth, LWA, and request signing it's no small effort: https://github.com/amzn/selling-partner-api-docs/blob/main/guides/developer-guide/SellingPartnerApiDeveloperGuide.md

They intend for us to generate a ruby client with swagger from the models in their repo, but we'd have to port the auth stuff they did for java https://github.com/amzn/selling-partner-api-models/tree/main/clients/sellingpartner-api-aa-java/resources/swagger-codegen/templates

Seems like it might be easier to just depend on https://rubygems.org/gems/aws-sigv4/ for the request signing since it has no deps https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/Sigv4/Signer.html

Also please vote for more support on amzn/selling-partner-api-models#43 They indicated they might do this for python based on level of interest.

from peddler.

gavinritchie avatar gavinritchie commented on September 4, 2024 4

Hey everyone, we've built a small gem called muffin_man to interface with the Selling Partner API. So far we've only implemented the Solicitations API because that's what we need right now, but we've got the auth working so it shouldn't be too hard to implement other endpoints. Feel free to contribute and/or use what we have so far.

from peddler.

ericcj avatar ericcj commented on September 4, 2024 4

I published a rubygem of the codegen for each model they provide with a minimal client based on muffin_man: https://github.com/ericcj/amz_sp_api

from peddler.

skatkov avatar skatkov commented on September 4, 2024 3

Interesting if we could crowdfund a rewrite to this library?

We did a rewrite to PA-API v5 before:
hakanensari/vacuum#83

But scope of this rewrite is way bigger (and I really need only one end-point from entire api). Really hard to justify spending so much time for an open source library (while my own projects will suffer from that).

from peddler.

hakanensari avatar hakanensari commented on September 4, 2024

Hey @skatkov, no immediate plans I am afraid. If you have something where you want to switch to the new API, you could take a stab first, and I jump in afterwards?

from peddler.

rdaniels avatar rdaniels commented on September 4, 2024

Amazon is forcing us to move to SP-API, have you started coding for this? If not I'm going to start coding for it

from peddler.

skatkov avatar skatkov commented on September 4, 2024

I'm not yeat doing anything on this, still kinda researching if I want to and need to do this.

from peddler.

rdaniels avatar rdaniels commented on September 4, 2024

Interesting if we could crowdfund a rewrite to this library?

We did a rewrite to PA-API v5 before:
hakanensari/vacuum#83

But scope of this rewrite is way bigger (and I really need only one end-point from entire api). Really hard to justify spending so much time for an open source library (while my own projects will suffer from that).

I would be willing to contribute financially to this

from peddler.

george-tigoris avatar george-tigoris commented on September 4, 2024

@ericcj indicated the possibility of using https://rubygems.org/gems/aws-sigv4/ for the request signing. Has anyone verified if this really works with the SP-API?

If it does and some of us only need a few end-points then we don't have to wait for a ruby client library.

I have not used https://rubygems.org/gems/aws-sigv4/ before but I could attempt to implement it if I know that it is expected to work.

from peddler.

skatkov avatar skatkov commented on September 4, 2024

@george-tigoris

Signing is pretty much standardized across different amazon api's. We already used aws-sigv4 in a vacuum rewrite

Check this out:
https://github.com/hakanensari/vacuum/blob/ad60efe9c4c4c6928466836c9d298d2797a48457/lib/vacuum/operation.rb#L68

from peddler.

ericcj avatar ericcj commented on September 4, 2024

@gavinritchie THANK YOU! We'd like to use several of the other API's and are planning on using swagger-codegen to generate them like https://github.com/amzn/selling-partner-api-models recommends. It would be helpful if we could leverage (copy and paste) a little bit of your muffin_man code, but selling-partner-api-models is under the Apache 2.0 license and muffin_man is MIT. Would you be be willing to grant use of muffin_man under the Apache 2.0 license and/or would you mind us using some of your code in a fork or different project that's based on the codegen-and-subclassing strategy vs the green field one you've taken?

from peddler.

iamricks avatar iamricks commented on September 4, 2024

New update from Amazon says we need to make the switch by September 30th, yikes...

from peddler.

ytsipun avatar ytsipun commented on September 4, 2024

Any plans?

from peddler.

rinoldsimon avatar rinoldsimon commented on September 4, 2024

Can we expect any milestones for SP-API support? This is critical.

from peddler.

skatkov avatar skatkov commented on September 4, 2024

It's too big of an undertaking for an open source project. @hakanensari and I did a rewrite for another, smaller, amazon library and took at least a month.

Amount of work here is staggering. So your best bet is to ask amazon to support ruby here or explore alternative libraries.

from peddler.

igorkasyanchuk avatar igorkasyanchuk commented on September 4, 2024

hello, does anyone has a suggestion what is the best option how to migrate to SP-API?

from peddler.

iamricks avatar iamricks commented on September 4, 2024

hello, does anyone has a suggestion what is the best option how to migrate to SP-API?

Your best bet is using: https://github.com/ericcj/amz_sp_api

from peddler.

stale avatar stale commented on September 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from peddler.

dbwinger avatar dbwinger commented on September 4, 2024

@hakanensari I see you started some work on the selling-partner branch last year. Any (change of) plans to update peddler to support it? Thanks for this awesome gem that's helped me a bunch over the last 8 years!

from peddler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.