[Feature request] graph options and hidden NOT_TAGGED about ansible-playbook-grapher HOT 11 CLOSED

@mysiki I'm thinking of respecting the value of display_skipped_hosts in ansible.cfg or ANSIBLE_DISPLAY_SKIPPED_HOSTS env var (https://docs.ansible.com/ansible/latest/reference_appendices/config.html#display-skipped-hosts).
If false/0, I will remove the corresponding tasks from the graph.

The idea is to be as close as possible to Ansible's behavior.

Oh yes, if it simple to use this it avoid to add command switch and many piece of code. And we have env var for manage it so I think it's good.
Just think to add it in documentation, because depend of callback using, some do not use this variable.

from ansible-playbook-grapher.

Great ! It work for me. I test it with ansible 2.8.

I don't make all possible test, only some classic -t and --skip-tags. But the render is great !

from ansible-playbook-grapher.

Hi,

• Graph option: I have thought about doing that. I will see if it's possible to do that. The rendering options (shapes, lines) are currently directly integrated in the graph
• It's normal: I chose to do it this way. It should be possible to completely skip them instead of reducing their opacity.

from ansible-playbook-grapher.

Thank for reply, for me the second point is really important. I have many many tasks and subplaybook in my project, generate graph without skip tasks will be really great. If you find some time for work on it, ping me, I can make some test really fast.

It's normal: I chose to do it this way. It should be possible to completely skip them instead of reducing their opacity.

from ansible-playbook-grapher.

I also suggest to omit tasks having when: False.

from ansible-playbook-grapher.

@mysiki I'm thinking of respecting the value of display_skipped_hosts in ansible.cfg or ANSIBLE_DISPLAY_SKIPPED_HOSTS env var (https://docs.ansible.com/ansible/latest/reference_appendices/config.html#display-skipped-hosts).
If false/0, I will remove the corresponding tasks from the graph.

The idea is to be as close as possible to Ansible's behavior.

from ansible-playbook-grapher.

@drzraf It should be possible to omit these tasks too

from ansible-playbook-grapher.

After I thought about it, I will not use the value of display_skipped_hosts. By default, Ansible doesn't display skipped tasks when using the option "-t" or "--skip-tasks".

I confused this behavior with the "when" condition when the tasks are displayed even though they are not run.

from ansible-playbook-grapher.

ok, you are right. So you just doesn't display skipped task (?). Can I test the PR ?

from ansible-playbook-grapher.

Yes. You can test it

from ansible-playbook-grapher.

Released in 0.10.0

from ansible-playbook-grapher.