Git Product home page Git Product logo

Comments (10)

Haehnchen avatar Haehnchen commented on May 29, 2024

so highlighting should be moved from annotation extension itself to inspections, so then it can be disabled.
also thinking of add whitelist ui in settings, also getting some failreports on drupal8

from idea-php-annotation-plugin.

drunken-monkey avatar drunken-monkey commented on May 29, 2024

Would also be interested in seeing this fixed. As you say, this occurs quite often in Drupal 8. Having an inspection setting for this ("Warn about missing annotation imports") would be perfect!
Also, the warning has only the label "Import" and currently links to "General » Annotator" – the former a bit monosyllabic, the latter pretty confusing.

(See also: http://youtrack.jetbrains.com/issue/WI-24731)

from idea-php-annotation-plugin.

davidsielert avatar davidsielert commented on May 29, 2024

Yeah I keep getting missing import as well whereas its not needed .. highly annoying as it highlights all the annotations..

from idea-php-annotation-plugin.

fgm avatar fgm commented on May 29, 2024

Ideally, the warning should be smart enough not to warn when the annotations are used in a Drupal 8 context, but to warn in more typical situations where they are needed. This probably needs a degree of cooperation with the Drupal support plugin.

from idea-php-annotation-plugin.

acelayawonnova avatar acelayawonnova commented on May 29, 2024

Is there any update on this?

from idea-php-annotation-plugin.

sylus avatar sylus commented on May 29, 2024

Chiming in here as well to see if any progress been made. Happy to help if given some guidance :)

from idea-php-annotation-plugin.

chx avatar chx commented on May 29, 2024

The warning is created here, I would guess it should be possible to find out whether the inspection defined as localInspection groupPath="PHP" shortName="AnnotationMissingUseInspection" displayName="Missing Import" etc is enabled or not and change this to createInfoAnnotation when not.. A bit shooting in the dark as I am not particularly familiar with the class hierarchy of IDEA but getting there. @sylus is this enough to start?

from idea-php-annotation-plugin.

donquixote avatar donquixote commented on May 29, 2024

Given a scenario where both types of annotations are used:
How should this plugin decide which annotation needs importing and which does not?

from idea-php-annotation-plugin.

drunken-monkey avatar drunken-monkey commented on May 29, 2024

Given a scenario where both types of annotations are used:
How should this plugin decide which annotation needs importing and which does not?

If fixing this just for Drupal 8 (don't know whether import-less annotations exist in other projects and, if so, how common they are), it might be possible to either cooperate with the "Drupal" plugin, or to just look whether an annotation with that classname exists in some sub-namespace of \Drupal.
However, only a single person here has actually requested this, I think the much more typical case is just wanting to disable the warnings completely.
Also, currently I can't even reproduce the problem anymore. I have enabled the new PHP > Annotation > Missing Import inspection, but I still don't get any warnings for them. That actually seems like a new bug caused by this. But in general, with this setting now present, it looks like this is resolved as far as my requirements are concerned. So thanks a lot for that!

from idea-php-annotation-plugin.

donquixote avatar donquixote commented on May 29, 2024

only a single person here has actually requested this

Make this +1 :)
I am working on something where I would have a Drupal module which uses Drupal and non-Drupal annotations.

I think the much more typical case is just wanting to disable the warnings completely.

Problem is, those annotations that do require an import won't work without it. So for those I really would appreciate the warning.

or to just look whether an annotation with that classname exists in some sub-namespace of \Drupal

Maybe implement this for a start, and then if the question pops up again, make these namespaces somehow configurable.

from idea-php-annotation-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.