Git Product home page Git Product logo

Comments (7)

erickzhao avatar erickzhao commented on May 26, 2024

Oh that makes sense since we're only deploying the /dist/ folder. I had added the signature back in, but in /images/signature.png instead of /src/images/signature.png.

Should I just add an /images/ folder into our /src/? Or should I move signature.png back to /static/ and have everyone change their image URL to /static/?

from mchacks6.

loreina avatar loreina commented on May 26, 2024

So is it now /dist/images/signature.png which goes to the same URL?

I think the idea is that it's too difficult for everyone to change their signature again, some people use clients that don't allow them to change the HTML directly.

from mchacks6.

krubenok avatar krubenok commented on May 26, 2024

I'm not sure how many people actually deployed their signatures yet. I'd be open to moving it. If we are moving it we should just put it in static with the rest of the assets though.

from mchacks6.

loreina avatar loreina commented on May 26, 2024

I'm down to move it if it's not affecting a lot of people. The sooner the better pls. 🙏

from mchacks6.

erickzhao avatar erickzhao commented on May 26, 2024

yep it was originally in static with the rest of the assets
would be best to move it back there

from mchacks6.

krubenok avatar krubenok commented on May 26, 2024

ok let's do it. Once this issue is closed I'll update the signatures on Notion and ping everyone to change.

from mchacks6.

loreina avatar loreina commented on May 26, 2024

Email sig now rests at https://mchacks.ca/static/signature.png

from mchacks6.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.