Git Product home page Git Product logo

Comments (4)

nisse3000 avatar nisse3000 commented on July 28, 2024

@computron, sounds sensible. I'll take care about the example you gave.

from matminer.

nisse3000 avatar nisse3000 commented on July 28, 2024

@computron, done (in my fork). I'm waiting with the pull request until @shyuep has released the next pymatgen version so that the additions of new and optimized OPs will also be part of that PR.

from matminer.

nisse3000 avatar nisse3000 commented on July 28, 2024

See PR #136.

from matminer.

computron avatar computron commented on July 28, 2024

Closing for now. Note that another option is that if a preset is "strong" enough (we really advocate for that preset, or there is a paper that advocates for that combination of settings that can be cited) we can create a new featurizer for it. That new featurizer can basically just call the old featurizer with the chosen parameter set. It should help in discoverability of that preset.

from matminer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.