Git Product home page Git Product logo

Comments (4)

scientes avatar scientes commented on August 23, 2024

note from my side:
i included the retired as im not sure that all i mark as retired actually are. Also you might notice that a player can ocurr up to three times in the csv due to there being a page for each player on test,T20,ODI if they plaeyed in them. there could be the possibility that a player might not be playing in one of those catergories but is still active in another.

from best11-fantasycricket.

roysti10 avatar roysti10 commented on August 23, 2024

i included the retired as im not sure that all i mark as retired actually are.

Could you elaborate on this? I didnt quite get you

Also you might notice that a player can ocurr up to three times in the csv due to there being a page for each player on test,T20,ODI if they plaeyed in them. there could be the possibility that a player might not be playing in one of those catergories but is still active in another.

I was actually gonna change this to one time when i got the time and delete the gametype column entirely. If he isnt active in the other formats , That should'nt matter cause his records will simply not be present in the respective format's folder. That shouldnt cause any problems.

from best11-fantasycricket.

scientes avatar scientes commented on August 23, 2024

i included the retired as im not sure that all i mark as retired actually are.

Could you elaborate on this? I didnt quite get you

i havent verfied that the data in the retired column is correct and that every player with retired=True is actually retired and i haven't checked if this also is the same for every gametype (meaning that when player is retired he is marked as such in every gametype)

from best11-fantasycricket.

roysti10 avatar roysti10 commented on August 23, 2024

i included the retired as im not sure that all i mark as retired actually are.

Could you elaborate on this? I didnt quite get you

i havent verfied that the data in the retired column is correct and that every player with retired=True is actually retired and i haven't checked if this also is the same for every gametype (meaning that when player is retired he is marked as such in every gametype)

Aah , then this issue can be dangerous if fixed, Ill verify this asap
Ill add a wontfix label for now

from best11-fantasycricket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.