AutoSubliminal not identifying embedded subtitles? about auto-subliminal HOT 22 CLOSED

'Web (en)' is not a valid language... it should be 'en' instead.

I only allow languages that are known in Babelfish (which is also used in subliminal).
https://github.com/h3llrais3r/Auto-Subliminal/blob/master/autosubliminal/diskscanner.py#L243-L247

About the imdb id error, see #18

from auto-subliminal.

AGH:( This could be a killer for me:(
All my srts are attached using mkvmerge named Web (en) (to identify source - and language)

Any idea how I can make your script idenfiy it? or if its babefish how to edit that?

from auto-subliminal.

I have an idea, but don't you have a problem with your media player? Because afaik a media player must also read the language and I doubt that 'web (en)' will be identified as a valid 'en' language...

Why do you add the source to the language?

from auto-subliminal.

h3hhraiser3r, are you on discord?
Dont want to explain in open chat if you understand?
morpheus65535 is a coder of Bazarr a script similar to yours using sublinimal etc... I recoemmd both you guys combine your skillz:)

As for me I'm a tester, new ideas kinda guy:)

So i think we could all help one another and speedup dev on AutoSub!

from auto-subliminal.

No not on discord.
Why wouldn't I explain? I just said I had an idea, but that's by implementing some custom code to identify 'web (en)' as 'en'. But like I said before, 'web (en)' is not a valid language, and I want to know if media players support this...

from auto-subliminal.

Sorry I mean I dont want to explain in public chat, but no matters:)
I'll look at way to get all my attached srts renamed to just en or ar etc..

from auto-subliminal.

I suppose you can do that with mkv tools (in bulk?)

from auto-subliminal.

We've been trying to make this with mkvpropedit which is part of mkvtoolnix but we can't get the right syntax. In fact, we're not sure it's possible at all:
https://github.com/mbunkus/mkvtoolnix/issues/2169

@h3llrais3r Are you aware of a python library that could do this?

from auto-subliminal.

Sorry, don't know such a library, but you should be able to do something with mkvtoolnix...
But I don't think you can select it based on the track name, you need to select based on track number...
See https://mkvtoolnix.download/doc/mkvpropedit.html#mkvpropedit.edit_selectors
track:tn -> t is identifier, n is number (track:s1 means first subtitle track)

But I suppose this is not that easy for everything because it will probably be different for different shows/movies...

Next to that, I checked some non touched mkv's of myself, and language should be in ISO3 code. (eng instead of en).

But what did you name exactly to web (en)? The language or the name?
Because when checking for embedded subtitles, we check the language field, not the name...
So you should still be able to name it like you want, as long as the language field is in iso3 format.

from auto-subliminal.

Thanks h3llrais3r for your help;) Seriously appreciated.

Yes cant select by name and all track numbers will be different.
Guess only option is to either leave it as is, or find a way to remove all srts from mkv files. Then edit my srt attaching to mkv script so it just names it en. I perfer 2 digit country codes as the NAME its more commonly used but yes for language its 3 digit.

So whats best way to delete ALL subtitles attached to a mkv file and do same to all mkv files found in recursive folders?:)

Then ill reatach all correctly again, will take few weeks but better to make it perfect.

from auto-subliminal.

Language should be 3 digit code... That's how mkvtoolnix shows it also... (If you select language from dropdown it results in 3 digit code)

You should really consider using standards, otherwise you'll always end up with problems...

from auto-subliminal.

Since this is not an issue, I'll close this.

from auto-subliminal.

yes language = 3 digit correct, but my "Web (en)" is in the name,
I need to edit the name of the srt (not language code).

Hope that make it clearer?:)

from auto-subliminal.

But what do you have as language? Because like I said before, the tool is parsing the language first (for 3 digit code), with a fallback of parsing the name (for 2 digit code).
https://github.com/h3llrais3r/Auto-Subliminal/blob/development/autosubliminal/diskscanner.py#L239-L252
So if your language is correct, the name doesn't matter at all...

from auto-subliminal.

3 digit language codes :)
eng etc..

from auto-subliminal.

Then there should be no problem... If you look at the code I mentioned in my previous comment, you'll see that it should parse the language first. If this is a valid language, it should never parse the name... That means you have files where the language is not set correctly...

from auto-subliminal.

strange one :) ok close this ill keep eye on things again thanks for help:)

from auto-subliminal.

Please check some of the files that give errors with mkvtoolnix and see what's set as language.

from auto-subliminal.

heres an example:

2017-12-06 20:47:57,884 ERROR Embedded subtitle track name u'Eight Diagram Pole Fighter (1984)-alE13' is not a valid language
2017-12-06 20:47:57,900 ERROR Embedded subtitle track name u'Eight Diagram Pole Fighter (1984)-alE13' is not a valid language
2017-12-06 20:47:58,697 ERROR Imdb id not found for Eight Diagram Pole Fighter (1984)

from auto-subliminal.

pls delete the images after you view it m8ty:)

from auto-subliminal.

Strange... Can you make a test setup for this file only? Can you enable debug logging in the tool, together with third party logging enabled.
Then scan this file only and send me the debug logging. I think we'll get more info from that.

from auto-subliminal.

gonna quite for then ight, will do tomorrow for you :)

from auto-subliminal.