Git Product home page Git Product logo

Comments (9)

branflake2267 avatar branflake2267 commented on May 31, 2024

Great idea!

from gwt-eclipse-plugin.

branflake2267 avatar branflake2267 commented on May 31, 2024

#124 - This will get uploaded to the snapshot later tonight.

screen shot 2015-12-28 at 6 47 46 pm

<extension
       point="com.google.gdt.eclipse.core.browser.launchMenus">
    <client
          class="com.sencha.eclipse.gss.GetMenus">
    </client>
 </extension>
import java.util.ArrayList;
import java.util.List;

import org.eclipse.core.resources.IProject;

import com.google.gdt.eclipse.core.browser.BrowserMenuPopulator.ILaunchMenus;
import com.google.gdt.eclipse.core.browser.LaunchMenuModel;

public class GetMenus implements ILaunchMenus {

  @Override
  public List<LaunchMenuModel> getMenus(IProject project) {
    List<LaunchMenuModel> list = new ArrayList<LaunchMenuModel>();
    list.add(new LaunchMenuModel("AAAAA", "chrome", "http://google.com"));
    list.add(new LaunchMenuModel("BBBBBB", "chrome", "http://docs.sencha.com"));
    list.add(new LaunchMenuModel("BBBBBB", "chrome", "http://sencha.com"));
    return list;
  }

}

Would this work?

from gwt-eclipse-plugin.

branflake2267 avatar branflake2267 commented on May 31, 2024

I may need to add something about the browser implementation. Anyway this will get uploaded tonight to the snapshot repo.

from gwt-eclipse-plugin.

ivmarkov avatar ivmarkov commented on May 31, 2024

Good to hear that you are picking up the idea.
I do not understand the need for the extension point you are suggesting though. The existing IDebugLaunch interface and its extension point would be enough isn't?

from gwt-eclipse-plugin.

branflake2267 avatar branflake2267 commented on May 31, 2024

I didn't want to use the existing wiring I didn't believe it had all the properties I needed to configure the menus properly and I didn't want to break the existing one as of yet.

from gwt-eclipse-plugin.

ivmarkov avatar ivmarkov commented on May 31, 2024

OK but I think you cannot get-by without IDebugLaunch, because besides displaying these items in the menu, you need to be capable of launching a debugger once the user has selected it in the menu. That's exactly what IDebugLaunch is doing anyway isn't it?

Currently the IDebugLaunch's extension point, com.google.gdt.eclipse.core.debugLauncher only has two properties:

  • class - the implementation of the launcher
  • label - the label which you can possibly display in the menu
   <extension
         point="com.google.gdt.eclipse.core.debugLauncher">
      <extensions
            class="com.github.sdbg.integration.jdt.ChromeDebugLaunch" 
            label="SDBG Chrome JS Debugger">
      </extensions>
   </extension>

Note that the label is part of the extension point and not a property on the IDebugLaunch interface itself (which is good!). How about we enrich the above extension point with additional - possibly optional - properties that you need for the menu? (Even though I'm not yet sure what they would be?)

from gwt-eclipse-plugin.

branflake2267 avatar branflake2267 commented on May 31, 2024

Gotcha. I see what you're saying. I put the label in the class, figuring it might be generated. The other extension point wasn't wired up correctly as of yet but I can revisit it and fix it. I may have to rewrite some of the core to get it done. I was hoping to take a shortcut, but you're right. :) Well anyway, I'm off with the family today. I might get some time tonight, but I'd say I'll aim to get this done thursday.

from gwt-eclipse-plugin.

branflake2267 avatar branflake2267 commented on May 31, 2024

Ah, yeah I see it clearly now. Ugh, yeah, that should be an easy fix later.

from gwt-eclipse-plugin.

branflake2267 avatar branflake2267 commented on May 31, 2024

Turns out the extension IDebugLauncher was what I did sometime ago and I completely glitched when I came back to look at this. My mistake, I've returned it to its previous operation. Funny how that happens to me now in then. :)

from gwt-eclipse-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.