generate manifest.json command about gush HOT 16 CLOSED

like this i guess https://github.com/cordoval/gush-1/pull/1/files

@kherge because now is

  [Herrera\Version\Exception\InvalidStringRepresentationException]
  The version string representation "@package-version@" is invalid.

from gush.

You have Box configured to search and replace @package_version@ and not @package-version@ (notice the underscore instead of the dash). Since it is not being replaced, you are actually declaring that your applications is version @package-version@, which Amend does not recognize as a valid semantic version.

You need to decide to either reconfigure Box to replace package-version or fix the class so that it uses package_version instead.

from gush.

same error but with package_version, hmm i think i am missing something from your box configuration

from gush.

Hey, I just wanted to let you know that I haven't forgotten about this. I've just been busier than usual.

from gush.

shipped you an email 👶

from gush.

I'm trying to figure out which repository I should be debugging. Do you want me to work on the fork you have under your handle, or the original one at @gushphp?

from gush.

this one is the official one @kherge gushphp/gush

from gush.

Okay. Do you have a test .gush.yml file I can use? I can't seem to get to the update command to test anything.

from gush.

did you run gush configure?

from gush.

I did, but it's asking for a bunch of information I don't have.

Do I need to create a test repository?

from gush.

👶 boss here:

~ cat ~/.gush/.gush.yml                                                        Luiss-MacBook-Pro-3 [13:07:21]
parameters:
    cache-dir: /Users/cordoval/.gush/cache
    adapter_class: \Gush\Adapter\GitHubAdapter
    home: /Users/cordoval/.gush
    authentication: { username: cordoval, password-or-token: youbet, http-auth-type: http_password }
    github: { base_url: 'https://api.github.com/', repo_domain_url: github.com }
    versioneye-token: NO_TOKEN

from gush.

Okay:

• If you intend on tagging your releases with a "v", like v1.3.7, you will need to add the following code to your Application::__construct() method:

        if ('@' . 'package_version@' !== $version) {
            $version = ltrim($version, 'v');
        }

• Update to Box 2.4.4 just to be safe.

Let me know if that works for you. Make sure that whenever you generate a phar, it is always for a tagged release.

from gush.

why not just @package_version@ ?

from gush.

you beast! Thanks a lot!

~ php gush.phar update                            Luiss-MacBook-Pro-3 [9:01:48]
Looking for updates...
Already up-to-date.

from gush.

Yay, glad it worked!

The reason it's not simply '@package_version@' = ... is because Box will replace it with the actual version of Gush.

from gush.

oh i see so it scans the source code, i see. I wonder if it would be better to use an annotation reader 👶 but it works so we are all good now Thanks @kherge

from gush.