Git Product home page Git Product logo

Comments (4)

jrfaller avatar jrfaller commented on August 19, 2024

Hi!

Sure this line is doing nothing, probably comes from a bad refactoring. Will remove it.

Cheers.

from gumtree.

husttroy avatar husttroy commented on August 19, 2024

Simply removing this line of code may not be the right thing to do. This class is to merge small diffs with the enclosing ones. For example, the following statements merge deleted code in the source tree.

gumtree/core/src/main/java/com/github/gumtreediff/actions/RootAndLeavesClassifier.java

Lines 70 to 75 in 29301b7

Set<ITree> fSrcDelTrees = new HashSet<>();
for (ITree t: srcDelTrees) {
if (!srcDelTrees.contains(t.getParent()))
fSrcDelTrees.add(t);
}
srcDelTrees = fSrcDelTrees;

I think you should do the same thing for other types of diffs, e.g., move and update.

from gumtree.

jrfaller avatar jrfaller commented on August 19, 2024

Hi!
Move operation is already performed at the level of maximum subtrees (whole subtree rooted at a node is moved when node is moved), in contrast with insert or delete which only apply to one node (and therefore can be tedious to represent when whole subtrees are added/deleted).

Normally there is nothing to do for moved trees.

By looking closely, I realize that there is a loop performed twice for no reason 😠 I will remove it as well.

from gumtree.

husttroy avatar husttroy commented on August 19, 2024

Aha, now I understand. Thanks!

from gumtree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.