Make downloads asyncronous about rust-bert HOT 3 CLOSED

Hello,

The library is by design currently synchronous, because the download part of it is a minimal feature.
To run the code in an asynchronous environment, please spawn a blocking thread:

#[tokio::main]
async fn main() {
    task::spawn_blocking(move || { let model = SentimentModel::new(Default::default()).unwrap(); });
}

from rust-bert.

Hello,

The dependencies download is asynchronous. The code is located at:

I am pushing some changes to make the overall function synchronous and use a local runtime instead. As I do not have code available to reproduce the issue, could you please check-out the branch async_download and let me know if this solves the issue?

from rust-bert.

Sorry for not mentioning, basically the reproduction is:

use rust_bert::pipelines::sentiment::SentimentModel;

#[tokio::main]
async fn main() {
    let model = SentimentModel::new(Default::default()).unwrap();

    // or
    let model = tokio::task::block_in_place(|| SentimentModel::new(Default::default())).unwrap();

    // or the following which you cannot do due to rust complaining about sending Rc between threads
    let model = tokio::task::spawn_blocking(|| SentimentModel::new(Default::default()).unwrap())
        .await.unwrap();
}

It should produce the Cannot start a runtime from within a runtime, let me know if it doesn't!

from rust-bert.