Build .... oddities... about terminal.gui HOT 4 OPEN

Please do! Thanks.

from terminal.gui.

A'ight.

A little of this already did get done and merged in PRs that were prepping to nuget-ify the analyzer project.

But I'll make a pass over everything to do with msbuild for what's in the solution, as well as nuget, first, since that'll work just fine as a self-contained PR, and then get into github workflows and scripting stuff.

from terminal.gui.

@tig

A couple of specific questions on elements in Terminal.Gui.csproj, as of v2_develop head at this moment, which is at f1fe7e7:

Why are these specified?

Line 31

    <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>

Not really a good idea to be in source control as the default. I'm likely going to put a condition on it so it only gets included if a configuration that explicitly targets a preview framework is selected (one of the new ones I'm adding).

Line 129

    <DocumentationFile>bin\$(Configuration)\$(AssemblyName).xml</DocumentationFile>

What is the purpose of this? It actually causes inconsistent behavior for certain build targets depending on the build environment and build procedure. Default path works for all.

from terminal.gui.

And in the packaging PropertyGroup, the authors and owners elements.

The "proper" values for those elements, according to nuget documentation, are the nuget profile names of those people or organization accounts. Other values are of course legal, but that's the documented recommendation. 🤷‍♂️

https://learn.microsoft.com/en-us/nuget/reference/nuspec#owners

https://learn.microsoft.com/en-us/nuget/reference/nuspec#authors

The docs say it's "ignored" by nuget.org, but that just means it doesn't actually assign formal ownership of the package. The metadata is still as specified in the nuspec.

from terminal.gui.