Unbind/destroy about scribe HOT 14 OPEN

Hm, are there any event bindings which are outside the DOM element Scribe is operating on? Like document level event bindings?

from scribe.

There may be, eg toolbar buttons or document-level for keyboard shortcuts.
All parts of plugin though.

Visit theguardian.com. On your mobile, download the Guardian iPhone app
theguardian.com/iphone and our iPad edition theguardian.com/ipadhttp://theguardian.com/iPad.
Save up to 57% by subscribing to the Guardian and Observer - choose the
papers you want and get full digital access. Visit
subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be
privileged. If you are not the named recipient, please notify the sender
and delete the e-mail and all attachments immediately. Do not disclose the
contents to another person. You may not use the information for any
purpose, or store, or copy, it in any way. Guardian News & Media Limited
is not liable for any computer viruses or other material transmitted with
or as part of this e-mail. You should employ virus checking software.

Guardian News & Media Limited is a member of Guardian Media Group plc. Registered
Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP. Registered
in England Number 908396

from scribe.

👍 - this is really important when there are multiple instances / usage in single-page js apps

Also it should give plugins a way to clean themselves up when the scribe instance is being removed.

from scribe.

+1

from scribe.

It’s lazy of us not to have done this from the onset, and for that I apologise – however we are using Scribe in a large application with many instances and these memory leaks have had no wide reaching implications to date, as far as we can tell. Thus, we probably won't get around to implementing this unless it becomes a problem for us (bigger fish to fry).

Having said all of that, this could definitely become an issue for consumers other than ourselves, so I hand this one off to the community.

from scribe.

👍 I'm using Scribe in conjunction with React and this is needed to keep state clean. Totally understand the bigger fish thing though, so maybe you'll be seeing a pull request from me in the near future.

from scribe.

+1 — currently working around this by cloning elements with DOM listeners (like the toolbar) but would be great if "destroy" was baked into the plugin architecture somehow

from scribe.

+1

from scribe.

Any news about this? I'm also putting this in a react app and would like to clean up.

from scribe.

I think we're looking for a suitable community contribution.

from scribe.

@rrees is there something simple to start with, like adding it to the api and set this = null and then step by step clean up plugins, event listeners et al?

from scribe.

@triptec I love changes that are simple so this sounds like a good place to start.

from scribe.

I'll look into it this weekend.

from scribe.

Thanks feel free to just implement the basic stub and then add the event listeners and plugins in a follow up.

from scribe.