Git Product home page Git Product logo

Comments (6)

OliverJAsh avatar OliverJAsh commented on September 24, 2024

Agreed!

Maybe we should just have tests to document all of the browser inconsistencies instead. The ones which pass are the ones we’ve fixed/patched, and the ones that fail remain broken. Thoughts? We are already doing this to an extend – it would be a case of moving more of the information out of BROWSERINCONSISTENCIES.md and into the test files themselves.

/cc @theefer

from scribe.

matthewmueller avatar matthewmueller commented on September 24, 2024

Just speaking personally, I found the browser inconsistencies doc super insightful. So I think a page of all known contenteditable bugs should exist somewhere. But right now it's just confusing whether scribe addresses them or not.

Tests would be great, but I also like the jsbins because you can play around with the bug to see if you can come up with a fix.

from scribe.

OliverJAsh avatar OliverJAsh commented on September 24, 2024

Hmm, OK. I just don’t want to duplicate explanations of bugs or the hyperlinks to their isolated cases across BROWSERINCONSISTENCIES.md and in the tests.

I wonder if we could leverage JSDoc in any way to make references to the browser inconsistencies from the code. Ideally, we could then generate a HTML file that displays the browser inconsistencies and our support for each one of them, based on the tests. I’m not sure how hard that would be to do…

from scribe.

theefer avatar theefer commented on September 24, 2024

It feels like having a separate file describe such issues, rather than just tests, is quite valuable to go and nag browser vendors. Maybe reduce duplication by referencing one from the other?

from scribe.

OliverJAsh avatar OliverJAsh commented on September 24, 2024

@theefer Yep, just need to figure out how to do the referencing.

from scribe.

OliverJAsh avatar OliverJAsh commented on September 24, 2024

.@robinedman suggested that we refer to browser inconsistencies in the patches/tests via links to GitHub issues. In these issues we can link to the isolated case and describe the inconsistency.

This means that if we update the isolated test case, or the description for the inconsistency, we need only update the GitHub issue.

This will also make it clear whether or not the browser inconsistency has been patched in Scribe (opened/closed).

from scribe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.