Comments (6)
Agreed!
Maybe we should just have tests to document all of the browser inconsistencies instead. The ones which pass are the ones we’ve fixed/patched, and the ones that fail remain broken. Thoughts? We are already doing this to an extend – it would be a case of moving more of the information out of BROWSERINCONSISTENCIES.md
and into the test files themselves.
/cc @theefer
from scribe.
Just speaking personally, I found the browser inconsistencies doc super insightful. So I think a page of all known contenteditable bugs should exist somewhere. But right now it's just confusing whether scribe addresses them or not.
Tests would be great, but I also like the jsbins because you can play around with the bug to see if you can come up with a fix.
from scribe.
Hmm, OK. I just don’t want to duplicate explanations of bugs or the hyperlinks to their isolated cases across BROWSERINCONSISTENCIES.md
and in the tests.
I wonder if we could leverage JSDoc in any way to make references to the browser inconsistencies from the code. Ideally, we could then generate a HTML file that displays the browser inconsistencies and our support for each one of them, based on the tests. I’m not sure how hard that would be to do…
from scribe.
It feels like having a separate file describe such issues, rather than just tests, is quite valuable to go and nag browser vendors. Maybe reduce duplication by referencing one from the other?
from scribe.
@theefer Yep, just need to figure out how to do the referencing.
from scribe.
.@robinedman suggested that we refer to browser inconsistencies in the patches/tests via links to GitHub issues. In these issues we can link to the isolated case and describe the inconsistency.
This means that if we update the isolated test case, or the description for the inconsistency, we need only update the GitHub issue.
This will also make it clear whether or not the browser inconsistency has been patched in Scribe (opened/closed).
from scribe.
Related Issues (20)
- allowBlockElements=false in Safari prevents entering new lines HOT 2
- Pressing Enter while having a selection in inline-mode does not delete the range content HOT 1
- Roadmap to making Safari support official?
- lodash dependecy still exists. HOT 10
- Pasting inserts paragraph tags even in inline-mode
- Remove Unexpected Usage of ES6 const HOT 2
- NPM releases improvements HOT 3
- Pull requests welcome? HOT 1
- Scribe commands not working when triggered in child iframe HOT 1
- whether consider supporting umd? HOT 2
- command plugin problem
- Edge compatibility HOT 1
- cjs version [email protected] does not work with browserify w/ deamdify
- UndoManager and a max length plugin
- Any chance of supporting lists?
- Un able to import Scribe using angular Cli
- plugin injection into existing `scribe` instance HOT 1
- Demo is broken
- Selection.range collapses when selecting the last word of a paragraph HOT 5
- Text alignment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scribe.