Comments (1)
This is now working. The test with no parameters set is optimized to run on a local system for quick testing with a simple pass/fail interface and a log file for details. It can have a flag passed in to log to the console for CI. It can also have different URLs or recipes provided, which might be useful in the future if we want to test our recipes more extensively.
I didn't have a great way to test the CI job without simply committing it and seeing what happened, but I now have most of the issues worked out. The one minor issue left is that we cannot use pip dependency caching for now. It seems like the Github action that supports pip dependency caching only supports it if the project tracks dependencies in a requirements.txt file. In our case, dependencies are tracked in a setup.cfg file. This doesn't prevent our job from running, but dependency caching would help speed things up.
The other issue is that #23 is still outstanding. I think this project is still in a place where we don't need to move heaven and earth to keep things working at all times. I am tracking when that merge request goes into pytube, and when it does I will upgrade. In the mean time, the CI runs of the test will fail.
from brownify.
Related Issues (20)
- Remove docstring type hint duplication HOT 1
- Fix docstring line continuation indentation HOT 1
- Add badges to repo HOT 4
- Youtube changes broke current Pytube version HOT 3
- RTD build is broken: cannot import attr module HOT 2
- Some RTD documentation not rendered due to libsndfile being missing HOT 2
- Add unit tests to CI HOT 1
- Reach 100% coverage on unit tests
- Consider refactoring the runner module
- Consider refactoring the parser
- Investigate enabling pip cache on Github actions
- Upload code coverage report and link to it from badge HOT 1
- Create a temporary fix until a new version is released HOT 1
- Get CI end-to-end test working HOT 2
- End to end test failing in CI with error about protobuf HOT 1
- We shouldn't need to manage protobuf versions in our install
- Work around pytube/Youtube integration issue HOT 1
- Switch back to pytube mainline once fixed HOT 1
- Convert time shifting parameter to be time-based HOT 2
- Make it possible to run without dependence on Pytube HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brownify.