Suggestion: use child_process.exec instead of spawn in child_process helper task about grunt HOT 4 CLOSED

Joining opts.args on space is a little naive, as arguments could contain spaces. Trying to quote them could be a huge mess.

from grunt.

Agreed on the naivety, that was the trade-off for maintaining a backwards compatible argument with the existing implementation. I guess from my perspective, if I had to put quotes around the argument in the command line, I'd expect to have to do the same when passing those values to this helper.

from grunt.

The built-in grunt file.expand method handles wildcard globbing, so you don't need to rely on the shell to do that. Not to mention that file globbing rules might be different on Windows, which could potentially cause portability issues.

I recommend using the built-in child_process helper (note, I just rewrote it today) along with file.expand to handle these scenarios. Also, you will probably have more control if you use handlebars programmatically via its JavaScript API instead of invoking it as a child process.

from grunt.

Cool, thanks very much for the pointer to file.expand, that accomplishes what I was looking for. I've trashed my implementation and I'll keep an eye out for the child_process to util move in the next release. Thanks for your help!

from grunt.