[CLOSED] Implementation of raw_input() about grumpy HOT 12 CLOSED

Comment by corona10
Sunday Feb 05, 2017 at 00:00 GMT

@trotterdylan Thank you for great and awesome review. I will try to fix it.

from grumpy.

Comment by corona10
Monday Feb 06, 2017 at 03:59 GMT

@trotterdylan Updated! I fixed codes as you commented. Actually, about using grumpy.File object is not 100% same as you intended. I found the simpler way.
And I add unit test code, but it should be improvement later time. I wish other guys could improve this unit test to check user's input and function's output. Unfortunately, In now time, this is out of my ability.

PTAL

from grumpy.

Comment by corona10
Tuesday Feb 07, 2017 at 04:07 GMT

@trotterdylan A lot of stuff!! I will do it as your comment. Thanks

from grumpy.

Comment by corona10
Thursday Feb 09, 2017 at 22:47 GMT

@trotterdylan Updated!! Please take a look.

from grumpy.

Comment by corona10
Monday Feb 13, 2017 at 20:36 GMT

@trotterdylan Updated. PTAL

from grumpy.

Comment by corona10
Tuesday Feb 14, 2017 at 07:53 GMT

@trotterdylan Updated.

p.s Can I get good materials to know when to use defer? I'm just using it as finally statement.

from grumpy.

Comment by trotterdylan
Tuesday Feb 14, 2017 at 20:47 GMT

@corona10 re: defer: It can be used like finally. But, like finally, it's only really useful if there are multiple possible paths for exiting the function or an exception (panic in Go) is raised. In this case, a panic is a fatal error so it doesn't really matter if we close things. The only time it's really important to run some code in the case of panic is if the panic may be handled somewhere (for the most part in the Grumpy code, we assume panic is fatal) or if you need to release some resource even in the event of a panic. Sometimes mutex falls into this category because it can otherwise cause a deadlock if not released. It's also good to guarantee that temp files are cleaned up. But otherwise, the possibility of panic is not usually a good reason to defer.

from grumpy.

Comment by corona10
Thursday Feb 16, 2017 at 01:48 GMT

@trotterdylan Thank you for review and great guide! I updated it and please take a look. Thanks to you, I learned about how Go works.

from grumpy.

Comment by corona10
Friday Feb 17, 2017 at 22:18 GMT

@trotterdylan Updated!! PTAL

from grumpy.

Comment by corona10
Sunday Feb 19, 2017 at 00:44 GMT

@trotterdylan Thank you for reviewing long days :-)

from grumpy.

Comment by pombredanne
Thursday Mar 02, 2017 at 10:42 GMT

@corona10 very nice :)

from grumpy.

Closing as this was imported by mistake. Already closed on google#233

from grumpy.