Git Product home page Git Product logo

Comments (7)

reatang avatar reatang commented on May 24, 2024

There is another question. The purpose of ping is to maintain the heartbeat when the connection is idle. But with kpDormant mechanism, the heartbeat will not be sent when there is no activeStreams. Does it violate the original intention of the ping function?

Related code

from grpc-go.

reatang avatar reatang commented on May 24, 2024

There is another question. The purpose of ping is to maintain the heartbeat when the connection is idle. But with kpDormant mechanism, the heartbeat will not be sent when there is no activeStreams. Does it violate the original intention of the ping function?

Related code

From my understanding, the keepalive function is mainly for stream rpc, not for unary rpc.

from grpc-go.

arvindbr8 avatar arvindbr8 commented on May 24, 2024

From my understanding, the keepalive function is mainly for stream rpc, not for unary rpc.

Keepalive is less likely to be triggered for unary RPCs with quick replies. Keepalive is primarily triggered when there is a long-lived RPC, which will fail if the keepalive check fails and the connection is closed.

Did you have Keepalive parameters being set to something other than default in the benchmark setup above?

from grpc-go.

reatang avatar reatang commented on May 24, 2024

From my understanding, the keepalive function is mainly for stream rpc, not for unary rpc.

Keepalive is less likely to be triggered for unary RPCs with quick replies. Keepalive is primarily triggered when there is a long-lived RPC, which will fail if the keepalive check fails and the connection is closed.

Did you have Keepalive parameters being set to something other than default in the benchmark setup above?

No, I'm using grpc's default configuration.

from grpc-go.

arvindbr8 avatar arvindbr8 commented on May 24, 2024

Could you send up the repo and maybe the wireshark dump posted above?

from grpc-go.

reatang avatar reatang commented on May 24, 2024

According to my latest learning results, this Ping may be BDPPing 😆 . WINDOW_UPDATE

if server setting:

server := grpc.NewServer(
		grpc.InitialWindowSize(1 << 24),
		grpc.InitialConnWindowSize(1 << 24),
	)

and client setting:

	options := []grpc.DialOption{
		grpc.WithInitialConnWindowSize(1 << 24),
		grpc.WithInitialWindowSize(1 << 24),
	}

then there will be no more

from grpc-go.

arvindbr8 avatar arvindbr8 commented on May 24, 2024

Glad this was resolved!

from grpc-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.