Comments (3)
Here are the diffs for a failing test:
diff --git a/runtime/fieldmask_test.go b/runtime/fieldmask_test.go
index 1af66ab4..3db815ef 100644
--- a/runtime/fieldmask_test.go
+++ b/runtime/fieldmask_test.go
@@ -28,6 +28,13 @@ func TestFieldMaskFromRequestBody(t *testing.T) {
name: "empty",
expected: newFieldMask(),
},
+ {
+ name: "EmptyMessage",
+
+ msg: &examplepb.ABitOfEverything{},
+ input: `{"oneof_empty": {}}`,
+ expected: newFieldMask("oneof_empty"),
+ },
{
name: "simple",
from grpc-gateway.
Thanks for your issue! I'm a little confused - you have a field where the presence of an empty message is significant? Surely an empty value isn't set or unset, it's just empty? What is the semantic meaning of a "set" empty value?
That said, if you want to contribute a fix for this, I'm all for it. I just don't really get it.
from grpc-gateway.
Thanks for response. Empty messages are useful as default choice in oneof. Similar to how it is defined here: https://github.com/grpc-ecosystem/grpc-gateway/blob/main/examples/internal/proto/examplepb/a_bit_of_everything.proto#L295
Here is another example. Lets say, you want the user to select a site and also give the user an option to explicitly select "all_sites", you could define a oneof like this:
oneof site_option {
google.protobuf.Empty all_sites = 1;
string site = 2;
}
Now, when someone sends all_sites
, I was hoping that I will get all_sites
set in fieldMask, but it is not set.
from grpc-gateway.
Related Issues (20)
- How to set cookie to http response header? Why it doesn't work. HOT 2
- Adding custom mux endpoint to openapi output HOT 3
- The API Gateway Vision HOT 2
- Support disabling default response rendering in bazel rule HOT 1
- Example and pattern annotations are not respect for query and path parameters HOT 8
- FieldMask as query param is not converted to snake case HOT 1
- an google.protobuf.Any type how to get openapiv2 output? HOT 1
- omit-enum-default-value Generates Invalid Spec for Enums with a Single Value HOT 1
- Content-Length not set in ForwardResponseMessage HOT 5
- Log level for errors is "info" HOT 5
- On `context deadline exceeded`, response headers aren't set HOT 3
- Add support for Etag & If-None-Match headers HOT 6
- TestOutgoingTrailerMatcher is non-deterministic
- How to remove @type or type_url after marshal google.protobuf.Any? HOT 3
- Feat: add http handler middleware HOT 1
- `X-Forwarded-For` header is not handled correctly HOT 2
- README.md: link to Wiki of "tool dependency" has been moved to go.dev HOT 1
- undefined: grpc.NewClient HOT 1
- proposal: Use version info from runtime/debug:BuildInfo when installed by go install HOT 2
- OpenAPI gen doesn't work default mapping. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-gateway.