Git Product home page Git Product logo

Comments (13)

kou avatar kou commented on July 22, 2024 1

こういうdiffがジャマなのでVisual Studioのバージョン違いも前処理で吸収したほうがよさそう。

-"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\bin\Hostx64\x64\cl.exe" /EP /nologo /W3 /MD /O2 /D_CRT_SECURE_NO_WARNINGS /we4013 /DMRB_STACK_EXTEND_DOUBLING /DMRB_DEBUG /I"D:\a\groonga\groonga\vendor\mruby-source\include" /I"D:\a\groonga\groonga\vendor\onigmo-source" /I"D:\a\groonga\groonga-build\vendor\mruby-build\host\include" -DMRB_PRESYM_SCANNING "D:\a\groonga\groonga\vendor\mruby-source\src\array.c" > "D:\a\groonga\groonga-build\vendor\mruby-build\host\src\array.pi"
+"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.39.33519\bin\Hostx64\x64\cl.exe" /EP /nologo /W3 /MD /O2 /D_CRT_SECURE_NO_WARNINGS /we4013 /DMRB_STACK_EXTEND_DOUBLING /DMRB_DEBUG /I"D:\a\groonga\groonga\vendor\mruby-source\include" /I"D:\a\groonga\groonga\vendor\onigmo-source" /I"D:\a\groonga\groonga-build\vendor\mruby-build\host\include" -DMRB_PRESYM_SCANNING "D:\a\groonga\groonga\vendor\mruby-source\src\array.c" > "D:\a\groonga\groonga-build\vendor\mruby-build\host\src\array.pi"

from groonga.

kou avatar kou commented on July 22, 2024 1

false positiveを減らして手動での確認の手間を減らしたいだけなので、そういう差分がちょろっと残っている分には別にジャマにならないんじゃないかな。

from groonga.

kou avatar kou commented on July 22, 2024 1

前処理を頑張りすぎて前処理の手間が増えると全体の手間（前処理の手間+手動での確認の手間）はあんまり変わらないかも。

from groonga.

kou avatar kou commented on July 22, 2024 1

https://developercommunity.visualstudio.com/t/Access-violation-in-_Thrd_yield-after-up/10664660?sort=active may be related.

Correct. See the commit message of 6d44714 for details.

from groonga.

kou avatar kou commented on July 22, 2024

6b6fe82 may be related.

from groonga.

kou avatar kou commented on July 22, 2024

6b6fe82 may not be related because re-running https://github.com/groonga/groonga/actions/runs/9379911833/job/26006202762 (this is for the previous commit of it) also failed.

GitHub Actions runner may be related:

Succeeded:

https://github.com/groonga/groonga/actions/runs/9379911833/job/25825796331#step:1:1

Current runner version: '2.316.1'
Operating System
  Microsoft Windows Server 2022
  10.0.20348
  Datacenter
Runner Image
  Image: windows-2022
  Version: 20240514.3.0
  Included Software: https://github.com/actions/runner-images/blob/win22/20240514.3/images/windows/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20240514.3
Runner Image Provisioner
  2.0.370.1

Failed:

https://github.com/groonga/groonga/actions/runs/9379911833/job/26006202762#step:1:1

Current runner version: '2.317.0'
Operating System
  Microsoft Windows Server 2022
  10.0.20348
  Datacenter
Runner Image
  Image: windows-2022
  Version: 20240603.1.0
  Included Software: https://github.com/actions/runner-images/blob/win22/20240603.1/images/windows/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20240603.1
Runner Image Provisioner
  2.0.370.1

from groonga.

otegami avatar otegami commented on July 22, 2024

I generated diff between succeeded and failed actions using the following command.

$ diff -u <(sed -E -e 's/^[^ ]+ (#[0-9]* [0-9.]* )?//' failure.txt) <(sed -E -e 's/^[^ ]+ (#[0-9]* [0-9.]* )?//' success.txt) > diff.txt

from groonga.

otegami avatar otegami commented on July 22, 2024

愚直に上記の差分を抜き出してみたのですが、
出力されている行が異なるので差分として出ているものもあり、もう少し工夫が必要そうでした。
ちょっと Ruby で書いてみます。

% diff -u -w <(sed -E -e 's/(Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC)\\[0-9.]+/\1\\VERSION/g' -e 's/^[^ ]+ (#[0-9]* [0-9.]* )?//' failure.txt) <(sed -E -e 's/(Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC)\\[0-9.]+/\1\\VERSION/g' -e 's/^[^ ]+ (#[0-9]* [0-9.]* )?//' success.txt) > diff.txt

差分の例

@@ -2042,6 +2061,7 @@
 CPP   ../../../groonga/vendor/mruby-source/src/gc.c -> ../mruby-build/host/src/gc.pi
 mkdir -p D:/a/groonga/groonga-build/vendor/mruby-build/host/src
 CPP   ../../../groonga/vendor/mruby-source/src/hash.c -> ../mruby-build/host/src/hash.pi
+"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\VERSION\bin\Hostx64\x64\cl.exe" /Zi /c /Fo"D:\a\groonga\groonga-build\vendor\mruby-build\host\mrbc\src\gc.obj" /nologo /W3 /MD /O2 /D_CRT_SECURE_NO_WARNINGS /we4013 /DMRB_STACK_EXTEND_DOUBLING /DMRB_DEBUG /DMRB_NO_PRESYM /DMRB_NO_GEMS /I"D:\a\groonga\groonga\vendor\mruby-source\include" /I"D:\a\groonga\groonga\vendor\onigmo-source" "D:\a\groonga\groonga\vendor\mruby-source\src\gc.c"
 mkdir -p D:/a/groonga/groonga-build/vendor/mruby-build/host/src
 CPP   ../../../groonga/vendor/mruby-source/src/init.c -> ../mruby-build/host/src/init.pi
 mkdir -p D:/a/groonga/groonga-build/vendor/mruby-build/host/src
@@ -2063,7 +2083,6 @@
 mkdir -p D:/a/groonga/groonga-build/vendor/mruby-build/host/src
 CPP   ../../../groonga/vendor/mruby-source/src/range.c -> ../mruby-build/host/src/range.pi
 mkdir -p D:/a/groonga/groonga-build/vendor/mruby-build/host/src
-"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\VERSION\bin\Hostx64\x64\cl.exe" /Zi /c /Fo"D:\a\groonga\groonga-build\vendor\mruby-build\host\mrbc\src\gc.obj" /nologo /W3 /MD /O2 /D_CRT_SECURE_NO_WARNINGS /we4013 /DMRB_STACK_EXTEND_DOUBLING /DMRB_DEBUG /DMRB_NO_PRESYM /DMRB_NO_GEMS /I"D:\a\groonga\groonga\vendor\mruby-source\include" /I"D:\a\groonga\groonga\vendor\onigmo-source" "D:\a\groonga\groonga\vendor\mruby-source\src\gc.c"
 CPP   ../../../groonga/vendor/mruby-source/src/readfloat.c -> ../mruby-build/host/src/readfloat.pi
 mkdir -p D:/a/groonga/groonga-build/vendor/mruby-build/host/src
 CPP   ../../../groonga/vendor/mruby-source/src/readint.c -> ../mruby-build/host/src/readint.pi

from groonga.

kou avatar kou commented on July 22, 2024

14.39.33519を14.40.33807に置換する（あるいはその逆）だけでいいかも。

from groonga.

otegami avatar otegami commented on July 22, 2024

14.39.33519を14.40.33807に置換する（あるいはその逆）だけでいいかも。

なるほどです。確かに十分ですねmm

diff -u <(sed -E -e 's/^[^ ]+ (#[0-9]* [0-9.]* )?//' failure.txt) <(sed -E -e 's/14\.39\.33519/14\.40\.33807/g' -e 's/^[^ ]+ (#[0-9]* [0-9.]* )?//' success.txt) > diff.txt

diff.txt

from groonga.

otegami avatar otegami commented on July 22, 2024

false positiveを減らして手動での確認の手間を減らしたいだけなので、そういう差分がちょろっと残っている分には別にジャマにならないんじゃないかな。

おっしゃる通りなので、一旦ここまでにして diff の結果で気になる部分がないかを見ていこうと思います!

from groonga.

otegami avatar otegami commented on July 22, 2024

私にはこれだ！と言うものを見つけられていないです。

Windows Server 2022自体の変更は、3日前に入っているので CI が落ち始めたタイミングとはあっていそう。

上記に関連手して調べてみたこと

from groonga.

kou avatar kou commented on July 22, 2024

https://developercommunity.visualstudio.com/t/Access-violation-in-_Thrd_yield-after-up/10664660?sort=active may be related.

from groonga.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.