Comments (8)
Just curious, is there a reason why you wouldn't make the change to redis-cluster.tmpl
in this repo? I believe this breaking change in 7.x is effectively the cause:
Modifying the bind parameter to a non-default value will no longer implicitly disable protected-mode (#9034)
So this project has been disabling protected-mode since redis version 3.2, and more depend on it being off than on.
from docker-redis-cluster.
Resolved in d5a8e12
New images will be published shortly
from docker-redis-cluster.
@jordyvanvorselen The simplest solution right now is that either you go back to a 6.2.x image, or you clone the repo and you update the file redis-cluster.tmpl
to remove protected mode for your own image you build and use.
The config parser is being rewritten, but no date on when that is done to enable easier config modifications rather then to build your own image
from docker-redis-cluster.
6.2.x
image does not seem to work for me. The follow command does not start any container successfully, nor does it give any errors. Any idea why?
docker run -d -e "IP=0.0.0.0" -p 7000-7005:7000-7005 grokzen/redis-cluster:6.2.10 --protected-mode no
The docker logs seems to suggest that there is no --protected-mode
or I did not add the option in the right way.
❯ docker logs 235315420ba7
/docker-entrypoint.sh: 102: exec: --protected-mode: not found
from docker-redis-cluster.
@ghShu If you look at how all processes is started, you will see that the entrypoint that dockers starts is not redis-server
command where your extra argument would be passed along into, but it starts a bash script and ignores any additional cli arguments that would otherwise be passed in to the running process by docker
from docker-redis-cluster.
Just curious, is there a reason why you wouldn't make the change to
redis-cluster.tmpl
in this repo? I believe this breaking change in 7.x is effectively the cause:Modifying the bind parameter to a non-default value will no longer implicitly disable protected-mode (#9034)
So this project has been disabling protected-mode since redis version 3.2, and more depend on it being off than on.
I agree. @Grokzen even mentioned in the README that this is not a production container at all and is for quick use for demo/presentation/development, so we can safely enable this for this repository.
Now, having that said, @Grokzen can you add the protected-mode on
in the redis.conf
and publish a new release to fix this issue as a hotfix? Then you can make things configurable later on.
from docker-redis-cluster.
Works! Thanks a lot @Grokzen!
from docker-redis-cluster.
Works well! Thanks @Grokzen, awesome 👍
from docker-redis-cluster.
Related Issues (20)
- PUBLIC NOTICE: Splitting cluster and sentinel into two separate docker images
- Rewrite travis-ci into github actions
- Old docker hub tags missing over night? HOT 1
- redis 'ready' event is not triggered HOT 3
- how to set every node password HOT 1
- redis.tmpl is missing
- Delete redis data after make down HOT 1
- Image for Apple M1 docker HOT 4
- Can I run a Redis cluster without a ".conf "configuration file like Mariadb Galera and just configure it all in the docker-comemater.yml file? HOT 1
- Cannot redirect when connecting from remote HOT 3
- Wrong redis version used HOT 3
- Images before < 6.x have been dropped from registry HOT 1
- Podman not supported HOT 5
- Image with tag `latest` not latest HOT 1
- Latest update has caused broken connection HOT 8
- Always more than 10 sec to "down" the container HOT 2
- Docker image with "latest" tag is not actually latest HOT 2
- Error when using jedis and test container for java HOT 1
- multiple critical CVEs in the image HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-redis-cluster.