Git Product home page Git Product logo

Comments (8)

ceckhardt avatar ceckhardt commented on July 28, 2024 2

Just curious, is there a reason why you wouldn't make the change to redis-cluster.tmpl in this repo? I believe this breaking change in 7.x is effectively the cause:

Modifying the bind parameter to a non-default value will no longer implicitly disable protected-mode (#9034)

So this project has been disabling protected-mode since redis version 3.2, and more depend on it being off than on.

from docker-redis-cluster.

Grokzen avatar Grokzen commented on July 28, 2024 2

Resolved in d5a8e12
New images will be published shortly

from docker-redis-cluster.

Grokzen avatar Grokzen commented on July 28, 2024 1

@jordyvanvorselen The simplest solution right now is that either you go back to a 6.2.x image, or you clone the repo and you update the file redis-cluster.tmpl to remove protected mode for your own image you build and use.

The config parser is being rewritten, but no date on when that is done to enable easier config modifications rather then to build your own image

from docker-redis-cluster.

ghShu avatar ghShu commented on July 28, 2024

6.2.x image does not seem to work for me. The follow command does not start any container successfully, nor does it give any errors. Any idea why?
docker run -d -e "IP=0.0.0.0" -p 7000-7005:7000-7005 grokzen/redis-cluster:6.2.10 --protected-mode no

The docker logs seems to suggest that there is no --protected-mode or I did not add the option in the right way.
❯ docker logs 235315420ba7
/docker-entrypoint.sh: 102: exec: --protected-mode: not found

from docker-redis-cluster.

Grokzen avatar Grokzen commented on July 28, 2024

@ghShu If you look at how all processes is started, you will see that the entrypoint that dockers starts is not redis-server command where your extra argument would be passed along into, but it starts a bash script and ignores any additional cli arguments that would otherwise be passed in to the running process by docker

from docker-redis-cluster.

kkoomen avatar kkoomen commented on July 28, 2024

Just curious, is there a reason why you wouldn't make the change to redis-cluster.tmpl in this repo? I believe this breaking change in 7.x is effectively the cause:

Modifying the bind parameter to a non-default value will no longer implicitly disable protected-mode (#9034)

So this project has been disabling protected-mode since redis version 3.2, and more depend on it being off than on.

I agree. @Grokzen even mentioned in the README that this is not a production container at all and is for quick use for demo/presentation/development, so we can safely enable this for this repository.

Now, having that said, @Grokzen can you add the protected-mode on in the redis.conf and publish a new release to fix this issue as a hotfix? Then you can make things configurable later on.

from docker-redis-cluster.

kkoomen avatar kkoomen commented on July 28, 2024

Works! Thanks a lot @Grokzen!

from docker-redis-cluster.

jordyvanvorselen avatar jordyvanvorselen commented on July 28, 2024

Works well! Thanks @Grokzen, awesome 👍

from docker-redis-cluster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.