Git Product home page Git Product logo

Comments (5)

everesio avatar everesio commented on June 13, 2024 1

Hi @radekg
I've already worked on the issue on the https://github.com/grepplabs/kafka-proxy/commits/bugfix/produce-ack-0
The fix is ready, but is need some more tests.

from kafka-proxy.

radekg avatar radekg commented on June 13, 2024 1

In our tests, it came up that the impact of this fix is so insignificant that it does not make sense to pursue any further optimizations. Thank you.

from kafka-proxy.

radekg avatar radekg commented on June 13, 2024

Hey @everesio, I already asked on #23. Would you mind pointing out to the place in the code where this can be fixed? I can prepare a pr.

from kafka-proxy.

everesio avatar everesio commented on June 13, 2024

Fixed in release 0.2.5.

from kafka-proxy.

radekg avatar radekg commented on June 13, 2024

Hey @everesio. Thank you, we are going to run this under test now and I'll give you an update.

One thing that came to my mind with regards to the potential perf hit. It is not possible to change the producer acks during an existing connection. That would imply that for each tuple of (connection, producer-id), it should be possible to infer acks based on the first produce message for a given producer on a given connection.

I'm going to have a look at that.

from kafka-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.