Git Product home page Git Product logo

Comments (3)

gregsdennis avatar gregsdennis commented on June 20, 2024 2

This was an intentional design decision.

While IEEE floating point numbers support a greater range, decimal supports greater precision, which often is needed more, for instance in financial applications.

JSON itself supports arbitrary-precision numbers, but it also does have a note that computers have limitations in numeric representation.

JSON Schema has no such requirements, instead deferring to JSON.

I've even marked the appropriate test as skipped in the test suite as listed on Bowtie (find my implementation and click "Details").

from json-everything.

gregsdennis avatar gregsdennis commented on June 20, 2024 1

@marcschier I have a workaround for you: copy the existing keywords that use decimal (i.e. MinimumKeyword, etc.) and modify them to use double. Then you just need to register them, and they should work just fine.

Here's a quick test I ran to make sure it works:

SchemaKeywordRegistry.Register<MinimumDoubleKeyword>(TestSerializerContext.Default);

var text = $$"""
    {
        "type": "number",
        "minimum": {{float.MaxValue}}
    }       
    """;
var schema = JsonSerializer.Deserialize(text, TestSerializerContext.Default.JsonSchema);
JsonNode instance = (double)float.MaxValue * 5;
var result = schema.Evaluate(instance, new EvaluationOptions { OutputFormat = OutputFormat.Hierarchical });

result.AssertValid();

from json-everything.

koepalex avatar koepalex commented on June 20, 2024

It is also not possible to generate the Json schemas:

var schema = new JsonSchemaBuilder()
                    .Type(SchemaValueType.Number)
                    .Format("float")
                    .Minimum(Convert.ToDecimal(float.MinValue))
                    .Maximum(Convert.ToDecimal(float.MaxValue))
                    .Const(0f)
                    .Build(),

Results into runtime error message: System.OverflowException : Value was either too large or too small for a Decimal.

from json-everything.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.