Git Product home page Git Product logo

Comments (8)

fradec avatar fradec commented on May 28, 2024

Or is the problem with patterns?
It would then miss an entry for ábstulit?

from hyphen-la.

eroux avatar eroux commented on May 28, 2024

Claudio's file is not run in the test.py file, so if you want to test this word you should add it in one of the accented solesmes files yes. Now, if the result is incorrect, then an additional pattern is needed indeed.

from hyphen-la.

fradec avatar fradec commented on May 28, 2024

Ok, your solution is good: i have added abstulit and ábstulit, to Solesmes 3 and one pattern: .ábs3tu which seem to be sufficient. But would I complete the list with all the forms of abstul…?

from hyphen-la.

eroux avatar eroux commented on May 28, 2024

If you're unsure, don't hesitate to add all the forms in the test file, maybe this will reveal other missing patterns

from hyphen-la.

fradec avatar fradec commented on May 28, 2024

Thank you for your help, I did some tests and it is not necessary to add too many words to the list, it will suffice like that.
I think the issue can be closed.

from hyphen-la.

fradec avatar fradec commented on May 28, 2024

I will update the other branch as soon as possible.

from hyphen-la.

eroux avatar eroux commented on May 28, 2024

Regarding what you did in 1d58e0b :

  • the alphabetical order should be kept for the sake of simplicity, so the new pattern should be around line 77, not line 1
  • I think that for the sake of consistency with lines 77-78, .áb4s3tu would be safer

from hyphen-la.

fradec avatar fradec commented on May 28, 2024

Ok, you're right. I changed everything according to your instructions, and added the other forms in the list, "cela ne mange pas de pain", and since it's done…

from hyphen-la.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.