Git Product home page Git Product logo

Comments (4)

rpspringuel avatar rpspringuel commented on July 24, 2024

Oh, and it would also be nice if commits to the main project repository would trigger a webhook which would automatically increment the version number.

from gregorio.

eschwab avatar eschwab commented on July 24, 2024

Could pull the version number from the commit hash. Would not be a nice +1 increment though.

Edit: git rev-list --count master is a possibility. Counts the number of commits on the branch.

from gregorio.

rpspringuel avatar rpspringuel commented on July 24, 2024

The issue I see with a simple count is that it doesn't have any reset possibilities.

If we are at version number 2.4.1, then ideally the hook should increment the last, and only the last number, changing the version number to 2.4.2. A subsequent commit should increment to 2.4.3, etc. However, at some point we're going to want to manually increment one (or both) of the first two numbers and reset the third: e.g. 2.5.0. A simple count would continue to increment the third number resulting in something like 2.5.4. This, I think, would be unduly confusing.

You are right, though, that only commits to the master branch should matter (as your suggestion implies).

from gregorio.

eschwab avatar eschwab commented on July 24, 2024

Fixed by #48 and #51. Please close.

from gregorio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.