Not working with latest @loadable/server & @loadable/babel-plugin `v5.16.0` version about loadable-components HOT 4 CLOSED

@loadable/[email protected] should fix the problem

from loadable-components.

@theKashey small update I think the issue is actually only with @loadable/babel-plugin.
And based on git commits I think the issue might be in isValidIdentifier function. But I have no expertise in writing babel plugins so I might be wrong.

I believe the problem is in the final return statement where we use loadableImportSpecifiers.find
So this:

function isValidIdentifier(path, loadableImportSpecifiers, lazyImportSpecifier) {
   ...
   return (
      path.get('callee').isMemberExpression() &&
      loadableImportSpecifiers.find(specifier => path.get('callee.object').isIdentifier({ name: specifier })) &&
      path.get('callee.property').isIdentifier({ name: 'lib' })
    )
}

should probably be this:

function isValidIdentifier(path, loadableImportSpecifiers, lazyImportSpecifier) {
   ...
   return (
      path.get('callee').isMemberExpression() &&
      loadableImportSpecifiers.every(specifier => path.get('callee.object').isIdentifier({ name: specifier })) &&
      path.get('callee.property').isIdentifier({ name: 'lib' })
    )
}

from loadable-components.

Thank you for the insight, that would greatly simply the fix process. @denchiklut +++

from loadable-components.

Root cause - broken "loadable" detection

In your code you just import your stuff as loadable, and that's it - https://github.com/denchiklut/ssr-boilerplate/blob/414ff83dc991d59e75db92a031f55b279ee19c15/src/client/components/%40shared/app/routes/index.tsx#L7
"Signatures" broken this moment requiring an explicit configuration, which you should want to implement (😉)

In any case, no breaking changes should occur even for not very widely used functionality and the behaviour has been corrected.
Currently it's too late to perform release, I'll do it tomorrow morning (and time zones are hard)

from loadable-components.