Comments (6)
I'm a little confused - I'm not seeing any errors in Firefox, and that code doesn't require that the object have a "width" setter - it simply checks to see if r.width is a value and if not, it adds it appropriately. The following lines BOTH evaluate as true if r.width is undefined:
if (!r.width) {...
if (r.width === undefined) {...
Can you show me an example of it generating an error in Firefox? Perhaps a codepen demo?
from gsap.
When I use the onDrag callback, Im getting this error on FF:
TypeError: setting a property that has only a getter` <- Draggable.js: 1528
And if you have a rect width zero width, this validate as false too.
r.width = 0;
if( ! r.width ) { ... // validate as true and run the conditional code, generating this error
See this pen:
http://codepen.io/gfelizola/pen/GeuvL
I'm using FF 29.0.1 on a Mac OSX 10.9.3
from gsap.
Sorry, I'm still confused :)
I'm on exactly the same system (Mac OSX 10.9.3, Firefox 29.0.1) and the only errors I see on that codepen link are a bunch of complaints that "TypeError: others.indexOf is not a function" which is in your code, not Draggable.
How can I see the error you're talking about?
Oh, and I used !r.width to be more concise and it's fine if it evaluates as true when the width is zero (I was aware of that) - I figured if you're hit-testing something that's reporting as zero-width, it deserves double-checking anyway.
Again, I'd really like to figure out how to see the error you're reporting. Nobody else has reported it and I'm not able to get it so I'm kinda baffled. Any more clues?
from gsap.
I didn't see any errors in draggable either, jack, just the others.indexOf
error.
I'm also perfectly fine with your use of lazy existence checking; I do it
all the time myself.
On Mon, Jun 2, 2014 at 1:25 PM, jackdoyle [email protected] wrote:
Sorry, I'm still confused :)
I'm on exactly the same system (Mac OSX 10.9.3, Firefox 29.0.1) and the
only errors I see on that codepen link are a bunch of complaints that
"TypeError: others.indexOf is not a function" which is in your code, not
Draggable.How can I see the error you're talking about?
Oh, and I used !r.width to be more concise and it's fine if it evaluates
as true when the width is zero (I was aware of that) - I figured if you're
hit-testing something that's reporting as zero-width, it deserves
double-checking anyway.Again, I'd really like to figure out how to see the error you're
reporting. Nobody else has reported it and I'm not able to get it so I'm
kinda baffled. Any more clues?—
Reply to this email directly or view it on GitHub
#43 (comment)
.
from gsap.
I don`t know why, but that pen is not updated with the last code version.
See at this new pen:
http://codepen.io/gfelizola/pen/msvzt
But I can only get this error at the onDrag
callback.
regardz
from gsap.
I tried that URL...still zero errors for me in Firefox. Can you be very specific about what I need to do to generate that error and precisely where I'd look?
from gsap.
Related Issues (20)
- v3.12.3 breaks positioning of scaled elements within inline svg HOT 2
- SplitText Elements with typescript HOT 2
- Promise.all dont resolve when overwrite HOT 2
- GSAP 3.12.3 and 3.12.4 break ScrollTrigger in latest Chrome HOT 4
- Flickering phenomenon in 3.12.4v HOT 2
- Negative gsap.ticker.time and timelines not playing HOT 4
- Production in vercel , module not found HOT 2
- Is it possible to use GSAP within a Web Worker? HOT 5
- Missing parameter for ScrollTrigger.clearScrollMemory in its TypeScript definition HOT 2
- requestAnimationFrame does not work on WebXR HOT 1
- What is the performance bottleneck of GSAP? HOT 1
- onStart callback is not called after pause HOT 6
- Gsap markers position not working on scroll+refresh | versions > 3.12.2 HOT 9
- GSAP ScrollTrigger causes error in Next.js HOT 3
- Nextjs Gsap ScrollTrigger snapping not working HOT 3
- String values for motionPath array in Typescript HOT 1
- SSL certificate has expired HOT 3
- PixiPlugin: Error with animating fillColor with PixiJS v8
- useGSAP does not cleanup properly when dependencies option is used HOT 1
- Pixijs docs on rotation are wrong
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gsap.