Crash when getting code coverage with emma about greendao HOT 11 CLOSED

Thanks for reporting. Could you check your theory, and debug which field is causing trouble here?
de.greenrobot.dao.DaoConfig.reflectProperties(DaoConfig.java:98)
Property property = (Property) field.get(null);

from greendao.

The field is $jacocoData. I quickly googled for it and found the following code http://www.eclemma.org/jacoco/trunk/coverage/org.jacoco.core/org.jacoco.core.internal.instr/InstrSupport.java.html
where the comment says "Name of the field that stores coverage information of a class"

from greendao.

Hmm, strange behavior. Wonder how to deal with that... Maybe just catch the exception, do a warn logging, and continue?

from greendao.

Yes, I also think this should just be ignored

from greendao.

Ok, in the meanwhile I changed the method to work correctly with emma. Would be nice, if you could include the fix in greenDAO code :-)

private static Property[] reflectProperties(Class<? extends AbstractDao<?, ?>> daoClass)
            throws ClassNotFoundException, IllegalArgumentException, IllegalAccessException {
        Class<?> propertiesClass = Class.forName(daoClass.getName() + "$Properties");
        Field[] fields = propertiesClass.getDeclaredFields();
        Map<Integer, Property> propertyMap = new HashMap<Integer, Property>();
        for (Field field : fields) {
            Property property = null;
            try
            {
                property = (Property) field.get(null);
                if(propertyMap.containsKey(property.ordinal))
                { 
                    throw new DaoException("Duplicate property ordinals");
                }
                propertyMap.put(property.ordinal, property);
            }
            catch(IllegalAccessException e)
            {
                // just ignore this, it could be instrumented code and contain additional properties
                // System.out.println(field.getName());
            }
        }
        Property[] properties = new Property[1];
        properties = propertyMap.values().toArray(properties);
        return properties;
    }

from greendao.

We just found a problem with this fix. Due to usage of the hashmap the order of the properties are not kept correctly, if you use more than about 20 columns in a table the order changes and therefore the queries are no longer correct. Using a LinkedHashMap fixes this problem, since it always maintains the order in which the properties have been inserted

from greendao.

The order of properties is given by the field ordinal. I am not sure if your code would take care of that. Let me give it a shot, I'll push a suggestion soon. Hope you can check it later.

from greendao.

Please check 5b3260f if that fixes these issues.

from greendao.

Hmm, no the problem is still existing. I think the problem is not the static modifier but the private modifier. If I change the if statement to

if ((field.getModifiers() & Modifier.STATIC) != 0 && (field.getModifiers() & Modifier.PRIVATE) == 0)

it works.

from greendao.

Thanks for the feedback. With a375028 it checks for static and public modifiers now. I assume this will fix the issue and close it. If there's another problem, let me know.

from greendao.

Ok, it works now. Thanks for fixing!

from greendao.