Git Product home page Git Product logo

Comments (3)

rostislav-simonik avatar rostislav-simonik commented on July 30, 2024

@archy-bold @p-kuen I think there are more things to do to fully support esm modules. I believe nexus-prisma as esm never worked. For the following reasons

  • all relative or folder imports are still in commonjs syntax (esm requires to have index.js or .js extension in import path)
  • code contains __dirname, which doesn't work under esm. It's exclusively commonjs variable, there is the way how to do it in esm by import.meta.url
  • there are broken imports from a few external packages with default export.

I think there is no point in supporting esm in nexus-prisma until nexus, and prisma will implement such support as well.

Feel free to share your thoughts about this.

from nexus-prisma.

rostislav-simonik avatar rostislav-simonik commented on July 30, 2024

Created discussion #693 to follow up on this topic. I'll prepare fix to remove esm build.

from nexus-prisma.

rostislav-simonik-nexus-prisma-admin avatar rostislav-simonik-nexus-prisma-admin commented on July 30, 2024

🎉 This issue has been resolved in version 1.0.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

from nexus-prisma.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.