Comments (4)
As this gem still supports ruby 2.2, you need to use rubocop v0.68.1
, you are probably using a newer version and that is why you are getting errors. Closing this one as it is not related to the functionality of the gem.
from graphql_devise.
You are right about that one. We haven't really gone through the style file yet, just copied it from another project which I new has most things we usually use. Don't worry about this one, I'll take care of it with @00dav00 as we have been discussing style conventions for a while. For now it should work if you use the correct version, and also your editor loads the other gem rubocop-rspec
which seems to be the problem for many of those warnings you are getting
from graphql_devise.
I was just about to address this actually. It looks like you're setting Style/MethodCalledOnDoEndBlock
to Enabled: true
which is hiding the same rule on line 58 which sets it to Enabled: false
. Which would you like?
from graphql_devise.
Hey while you were mentioning Styling fixes in my latest PR, I decided to run rubocop with the version you requested:
prompt> gem list rubo
*** LOCAL GEMS ***
rubocop (0.68.1)
rubocop-performance (1.3.0)
rubocop-rspec (1.36.0)
but I'm still getting those errors. I'm wondering what version of rubocop-rspec
you're using?
prompt> rubocop | grep Warn
.rubocop.yml:1: `require` is concealed by line 2
.rubocop.yml:46: `Style/MethodCalledOnDoEndBlock` is concealed by line 58
.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout
Warning: unrecognized cop RSpec/MultipleExpectations found in .rubocop.yml
Warning: unrecognized cop RSpec/ExampleLength found in .rubocop.yml
Warning: unrecognized cop RSpec/RepeatedDescription found in .rubocop.yml
Warning: unrecognized cop RSpec/MessageSpies found in .rubocop.yml
Warning: unrecognized cop RSpec/NestedGroups found in .rubocop.yml
Warning: unrecognized cop RSpec/ContextWording found in .rubocop.yml
I'm getting a little over 300 offenses when I run rubocop from the terminal. Most of them are double quote styling fixes but a few are Metrics related. Just an FYI.
from graphql_devise.
Related Issues (20)
- Override `graphql_name` to allow for shared mutations HOT 2
- GraphQL::Schema::DuplicateNamesError HOT 5
- how to set current_resource for both authenticated and unauthenticated fields HOT 1
- Support for ruby-graphql v2 HOT 3
- A class must be provided when mounting a model. String values are no longer supported HOT 3
- Mount only necessary operations in existing schema. HOT 3
- Authenticate non-root fields HOT 6
- Cannot make it work with Mongoid HOT 5
- `context[:controller]` is nil when trying to login HOT 1
- Scoping auth tokens to more than one model HOT 1
- If expiry was in epoch seconds, it may be out of the range of INT. HOT 1
- Disable introspection HOT 1
- Support graphql v2.1 HOT 4
- NoMethodError: undefined method `resource=' for nil:NilClass HOT 5
- Add ability to customize raise_user_error_list and raise_user_error_list
- Add ability to customize raise_user_error_list method HOT 11
- Unable to set my message from #inactive_message method HOT 7
- NoMethodError: undefined method `case_insensitive_keys' for nil:NilClass HOT 5
- Is there a way to use the default devise template views? HOT 1
- Uninitialized constant `GraphqlDevise::SchemaPlugin` After trying to mount `graphql_devise` in my schema HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql_devise.