Git Product home page Git Product logo

Comments (4)

mcelicalderon avatar mcelicalderon commented on May 18, 2024 1

As this gem still supports ruby 2.2, you need to use rubocop v0.68.1, you are probably using a newer version and that is why you are getting errors. Closing this one as it is not related to the functionality of the gem.

from graphql_devise.

mcelicalderon avatar mcelicalderon commented on May 18, 2024 1

You are right about that one. We haven't really gone through the style file yet, just copied it from another project which I new has most things we usually use. Don't worry about this one, I'll take care of it with @00dav00 as we have been discussing style conventions for a while. For now it should work if you use the correct version, and also your editor loads the other gem rubocop-rspec which seems to be the problem for many of those warnings you are getting

from graphql_devise.

aarona avatar aarona commented on May 18, 2024

I was just about to address this actually. It looks like you're setting Style/MethodCalledOnDoEndBlock to Enabled: true which is hiding the same rule on line 58 which sets it to Enabled: false. Which would you like?

from graphql_devise.

aarona avatar aarona commented on May 18, 2024

Hey while you were mentioning Styling fixes in my latest PR, I decided to run rubocop with the version you requested:

prompt> gem list rubo

*** LOCAL GEMS ***

rubocop (0.68.1)
rubocop-performance (1.3.0)
rubocop-rspec (1.36.0)

but I'm still getting those errors. I'm wondering what version of rubocop-rspec you're using?

prompt> rubocop | grep Warn
.rubocop.yml:1: `require` is concealed by line 2
.rubocop.yml:46: `Style/MethodCalledOnDoEndBlock` is concealed by line 58
.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout
Warning: unrecognized cop RSpec/MultipleExpectations found in .rubocop.yml
Warning: unrecognized cop RSpec/ExampleLength found in .rubocop.yml
Warning: unrecognized cop RSpec/RepeatedDescription found in .rubocop.yml
Warning: unrecognized cop RSpec/MessageSpies found in .rubocop.yml
Warning: unrecognized cop RSpec/NestedGroups found in .rubocop.yml
Warning: unrecognized cop RSpec/ContextWording found in .rubocop.yml

I'm getting a little over 300 offenses when I run rubocop from the terminal. Most of them are double quote styling fixes but a few are Metrics related. Just an FYI.

from graphql_devise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.