Add overloaded SmartContract.bind() function that can take a string about graph-tooling HOT 10 CLOSED

@schmidsi since Address.fromString() is now available. i guess we can close this?

from graph-tooling.

I think this was imagined as a further convenience, but I agree that this is probably not necessary, closing 🙏

from graph-tooling.

Is there any way to overload bind to take an address or a string as a first parameter?

from graph-tooling.

Nope, overloading results in TypeScript compile errors like this one:

ERROR TS2300: Duplicate identifier 'index/LANDRegistry.bind'.

   static bind(address: string, blockHash: H256): LANDRegistry {
          ~~~~
 in index.ts(919,9)

from graph-tooling.

We may be able to use overload lists for this, assuming AssemblyScript allows it: https://blog.mariusschulz.com/2016/08/18/function-overloads-in-typescript#version-4-function-overloads. I can try that.

from graph-tooling.

Nah, doesn't work with AssemblyScript.

from graph-tooling.

It works in AssemblyScript but with some limitations. For now you need explicitly resolve all generic types for overloaded functions. In future this will be more fancy.

See this example

from graph-tooling.

@MaxGraey Oh sweet, we'll give that a shot. It looks good enough for the moment. Thanks for the pointer!

from graph-tooling.

What is this tracking now? Having the overloaded version? Because we do have Address.fromString.

from graph-tooling.

Yeah, multiple implementations of SmartContract.bind() (one with an Address, one with a string parameter). It is a low priority issue right now.

from graph-tooling.