Git Product home page Git Product logo

Comments (6)

thestinger avatar thestinger commented on June 1, 2024

It could be made possible to update components in the OS without enabling them. I don't really think we should do something differently about this in Apps. Play Store is genuinely a dependency of Play services and needed for it to be able to install/update dynamite modules, etc.

from apps.

thestinger avatar thestinger commented on June 1, 2024

I don't think we want to do this.

from apps.

thestinger avatar thestinger commented on June 1, 2024

Maybe @muhomorr has a different opinion. I think the best solution would be if updating apps didn't re-enable them, although it's such a low priority and I don't really think we want to maintain changes for that downstream.

However, you do really need Play Store for Play services to work properly even if you don't use it directly at all so this specific example isn't something we want to do anything extra to support.

from apps.

muhomorr avatar muhomorr commented on June 1, 2024

There's a difference between having Play services and Play Store on different release channels and allowing to update Play services or Play Store independently. Even though Play services doesn't depend on a specific version of Play Store (and vice versa), they are expected to be on versions that aren't too far apart. Allowing updates of one but not the other would allow having Play services many months newer than the Play Store, and vice versa.

from apps.

jorgeluiscarrillo avatar jorgeluiscarrillo commented on June 1, 2024

I think I need to clarify since based on @thestinger's comments I feel there was a misunderstanding that I was requesting an OS-level change.

An error check was added that blocks updates of Play services because one of it's dependencies, in this case Play Store, is disabled. Unattended updates for Play services won't work since the user now has to manually re-enable the Play Store to get around this restriction.

Allowing updates of one but not the other would allow having Play services many months newer than the Play Store

I am proposing that we allow this to happen (as it did previously) and let the user be responsible for reduced/broken functionality.

Consider the "Play services for AR" situation. Users have the option to install and disable this app even though technically apps depending on it won't function "properly" (I assume that is why it tries to install itself). Like Play services for AR, the Play Store is just another regular sandboxed app on GrapheneOS. Requiring Play Store to be enabled after the user has decided to disable it makes the disabling user installed apps feature not as useful for this app which shouldn't be the case since it isn't special.

from apps.

girlbossceo avatar girlbossceo commented on June 1, 2024

let the user be responsible for reduced/broken functionality.

I don't understand what's the point of doing this? It doesn't have any benefits at all other than having a half-baked installation of sandboxed Google Play which breaks other apps and future ones you install. Even if said "responsible users" are aware this is completely broken and unintended, said people are still going to be inclined to send bug reports asking us to fix something we can't fix because we do not develop Play services.

Sure this setup "works for you", but this is not something the general public should be able to do because not everyone is going to be aware this is a broken setup.

Consider the "Play services for AR" situation. Users have the option to install and disable this app even though technically apps depending on it won't function "properly" (I assume that is why it tries to install itself).

This isn't the same thing because Play services for AR is not a critical component of Play services like Play Store is.

from apps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.