test_good_dirs fails with strange error about blue HOT 6 CLOSED

Confirmed. This is a blocker for 0.9.0

from blue.

For me this only happens with the Python 3.7 environment, reproducible locally with tox -e py37

from blue.

Notice the draft PR in #73

What is super weird is that the test suite only fails with Python 3.6 and 3.7, and there only with --check and not --diff. Even stranger, if you activate the py36 or py37 venvs and run blue from the command line, either with --check or --diff it works.

Because the resulting coverage lines are different, my suspicion is that we need to monkey patch things differently for Python < 3.8, but I don't have any other ideas more than that.

I'm stalled, and I'm pretty tempted to get out of this by just dropping Python 3.6 and 3.8! What do you think @grantjenks

from blue.

@warsaw I took a look following your mention of this issue and I think I figured it out. It's a fun one, the perfect storm of a couple things. Find me at pycon!

from blue.

@hauntsaninja Oh I can't wait! I have a thing this morning but I'll come find you afterward.

from blue.

Thank you.

from blue.