Git Product home page Git Product logo

Comments (3)

ddelponte avatar ddelponte commented on August 12, 2024

Hi @pjdvmalan and thank you for submitting this issue!

This is not a bug and is working as expected.

By default, the user's email address is not stored in the database. Because it's not stored in the database, we have no way of checking for duplicates.

Here's a link to the code within the command object that queries the database for duplicate users:
https://github.com/grails-plugins/grails-spring-security-ui/blob/master/plugin/grails-app/controllers/grails/plugin/springsecurity/ui/RegisterController.groovy#L272

And, please also notice, there is no email associated with the user domain class so no checking of duplicates can be done.

Here's a link to the template used to generate the user domain class:
https://github.com/grails-plugins/grails-spring-security-core/blob/master/plugin/src/main/templates/Person.groovy.template

I will mark this as "Not a bug" and close

from grails-spring-security-ui.

pjdvmalan avatar pjdvmalan commented on August 12, 2024

Thank you for your feedback. Much appreciated & noted.

I guess that the issue arise from the following in the documentation:

RegisterController and its GSPs assume that your User domain class has an email field. Be sure to either rework the workflow (using the s2ui-override script) if you don’t need an email confirmation step or add an email field.

Some of the functionality/flow depends on an email adres presend - I am going on the principle that people do sometimes forget their password.

This may be something to be considered int the architecture going forward ... detect if an email is defined. If so - check for duplication.

Just a suggestion.

from grails-spring-security-ui.

ddelponte avatar ddelponte commented on August 12, 2024

This may be something to be considered int the architecture going forward ... detect if an email is defined. If so - check for duplication.

Thanks @pjdvmalan !

Would you be so kind as to submit your suggested improvement as a new issue?

from grails-spring-security-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.