Git Product home page Git Product logo

Comments (5)

simonswine avatar simonswine commented on May 23, 2024

Hey @eilonmonday. I am not able to reproduce this locally, on Kubernetes 1.25

$ helm repo add grafana https://grafana.github.io/helm-charts
$ helm repo update
$ kubectl create namespace pyroscope-test
$ curl -Lo values-micro-services.yaml https://raw.githubusercontent.com/grafana/pyroscope/main/operations/pyroscope/helm/pyroscope/values-micro-services.yaml
$ helm -n pyroscope-test install pyroscope grafana/pyroscope --values values-micro-services.yaml

All of those commands succeed.

It would be good if you could provide a few more details about when you see the error and also if and how you modified values-microservices.yaml

from pyroscope.

jmtt89 avatar jmtt89 commented on May 23, 2024

maybe helm or Go version?

~/helmtest]$ helm version
version.BuildInfo{Version:"v3.9.2", GitCommit:"1addefbfe665c350f4daf868a9adc5600cc064fd", GitTreeState:"clean", GoVersion:"go1.17.12"}

reproduce error:

~/helmtest]$ curl -Lo values-micro-services.yaml https://raw.githubusercontent.com/grafana/pyroscope/main/operations/pyroscope/helm/pyroscope/values-micro-services.yaml
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2336  100  2336    0     0   7277      0 --:--:-- --:--:-- --:--:--  7277
~/helmtest]$ helm template pyroscope grafana/pyroscope --values ./values-micro-services.yaml --dry-run --debug
install.go:178: [debug] Original chart version: ""
install.go:195: [debug] CHART PATH: /home/jtorres/.cache/helm/repository/pyroscope-1.4.0.tgz


Error: template: pyroscope/templates/deployments-statefulsets.yaml:100:70: executing "pyroscope/templates/deployments-statefulsets.yaml" at <$values.readinessProbe>: wrong type for value; expected map[string]interface {}; got interface {}
helm.go:84: [debug] template: pyroscope/templates/deployments-statefulsets.yaml:100:70: executing "pyroscope/templates/deployments-statefulsets.yaml" at <$values.readinessProbe>: wrong type for value; expected map[string]interface {}; got interface {}

Regardless of that, if you want to fix the problem, as I said in my other comment, just need a little change on the helm chart.

from pyroscope.

Icarus9913 avatar Icarus9913 commented on May 23, 2024

I reproduced it too. kubernetes version v1.25.6

steps:

$ helm repo add grafana https://grafana.github.io/helm-charts
"grafana" has been added to your repositories

$ helm repo update

$ helm -n kube-system install pyroscope grafana/pyroscope
Error: INSTALLATION FAILED: template: pyroscope/templates/deployments-statefulsets.yaml:100:70: executing "pyroscope/templates/deployments-statefulsets.yaml" at <$values.readinessProbe>: wrong type for value; expected map[string]interface {}; got interface {}

$ helm version
version.BuildInfo{Version:"v3.9.0", GitCommit:"7ceeda6c585217a19a1131663d8cd1f7d641b2a7", GitTreeState:"clean", GoVersion:"go1.17.5"}

from pyroscope.

MikeCockrem avatar MikeCockrem commented on May 23, 2024

FWIW: I had this issue, I resolved it by updating helm

from pyroscope.

jcv-jed avatar jcv-jed commented on May 23, 2024

In our case, we are using helm v3.8.1, which is using golang 1.16.
It seems that before golang 1.18, all arguments are evaluated.
Ref: https://tip.golang.org/doc/go1.18#htmltemplatepkghtmltemplate

from pyroscope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.