Comments (6)
Yeah this would be awesome... Right now we're trying to figure out a way to distinguish "our" code from library code. For example:
Here:
services/customer/client.py:16
is part of our code while
flask/app.py
is part of the flask package in python
So we could link to services/customer/client.py:16
in our github repo and if there was some way to know on the frontend that flask/app.py
is not in our repo then we could just use that logic to determine whether or not to include the linking behavior on the frontend.
Right now thats the blocker here (we may need to do more digging on the backend for this).
from pyroscope.
Just ftr I think that we would probably try and do something like this:
Which would keep the current behavior that "zooms" in on a node when you click on it. Then after it's clicked on we could make it slightly larger height and show a little github icon inside of there that would link to:
https://github.com/pyroscope-io/[REPO_NAME]/services/frontend/server.py:38
from pyroscope.
Easier way to distinguish on frontend may be just create a hard coded list. libraries-denylist.js
that looks like export new set(['list of top 1000 libraries for each language'])
then check when rendering each box
from pyroscope.
Think it'll look ok to add the github logo to every single box? Also how would user access the link for the boxes that are too thin to even have words in them
from pyroscope.
Yeah that might work and I don't think we would add the github logo to every box, just the one in focus (when a box is in focus). So in the picture above it would only be that row that has the logo inside of it.
The reason for this is because what you said about the boxes that are too thin.. If you have selected a particular node (aka clicked on one), then the nodes above it dim and the node itself becomes the "base" and takes up 100% of the width.
I think this would ensure that most of the time when the logo is included in this "focused" node then it wont get too crowded
from pyroscope.
Just made our demo repos public so this could work now:
Python: https://github.com/pyroscope-io/hotrod-python
Ruby: https://github.com/pyroscope-io/hotrod-ruby
Go: https://github.com/pyroscope-io/jaeger.git
/cc @LouisInFlow
from pyroscope.
Related Issues (20)
- Helm: Update from the agent helm chart to the alloy one HOT 1
- Doesn't work with Python3.12 HOT 1
- Trace exemplars HOT 1
- Memory allocation profiling in .NET HOT 7
- [pyro UI] Tags don't work as expected
- Fail to run alloy to pull profiles HOT 1
- Reduce confusion with profile types in Pyroscope HOT 2
- Panic during Ad Hoc profile upload
- profiles from python sdk have -1 as line number
- The sample count displayed is wrong
- Explain basics about flamegraph / profiles HOT 3
- Provide API to access span IDs in profiles
- Memory profiling with eBPF
- CVE-2023-6992 zlib, CVE-2023-42366 busybox HOT 1
- Traces get rejected if labels have dashes in them HOT 3
- Add support for column numbers
- Restart the pyroscope service and find that 40 minutes of data will be lost HOT 2
- Inaccurate numbers in the sandwich view
- `helm install --wait` results in a failed deployment
- Make Rideshare examples use k6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyroscope.