Use a pool of browsers to execute render requests about grafana-image-renderer HOT 7 CLOSED

Looks like alpine now has 79.0.3945.88-r0 in 3.11 and in edge

from grafana-image-renderer.

Or https://github.com/thomasdondorf/puppeteer-cluster

from grafana-image-renderer.

Nice find! That looks like it would do pretty much exactly what we need, and the CONCURRENCY_CONTEXT option should allow us to process multiple requests in a single chromium instance.

from grafana-image-renderer.

@DanCech Looking at puppeteer/puppeteer#4949 introducing emulateTimezone it mentions that "Blocked on a Chromium roll to v79.0.3923.0 (r699550) or later, though." which is a quite recent version so could be hard to support this maybe. In addition, we need to upgrade puppeteer to v2.0.0, not sure if that would cause any problems. But will look into this and try it out.

from grafana-image-renderer.

It looks like we could let puppeteer install chromium itself rather than pre-installing from the alpine edge package, which in theory at least should be more reliable since it's going to download the same version the release was tested against. If we go that route and update to 2.0.0 then the per-page timezone should hopefully Just Work.

from grafana-image-renderer.

@DanCech problem though is that the puppeteer cannot automatically download chromium for alpine, at least that didn't work before. But one alternative would be to add an ubuntu image as well and/or build a custom one.

from grafana-image-renderer.

Aha, that is a problem then, since the alpine packaged version in edge right now is 78.0.3904.108-r0 https://pkgs.alpinelinux.org/package/edge/community/x86_64/chromium which seems to be the current stable release as that's the version in the ubuntu etc repos also.

from grafana-image-renderer.