Comments (5)
@gr2m could you verify this or is this "a feature"? :)
from initials.
Good catch! Yes, this is a bug!
initials([['Moe Minutes', 'Moe Min'])
// returns ["MMi", "MMi"]
// should return sth like ["MoM", "MMi"]
I think this is rather an edge case, so it's not a top priority to fix, but something nice for the backlog.
from initials.
It breaks here:https://github.com/gr2m/initials/blob/gh-pages/initials.js#L176
splice
changes the array dynamically in the for-loop.
possible solution:
possibleInitials[i] = undefined
and possibleInitials = possibleInitials.filter(Boolean)
breaks 13 tests.
from initials.
closing in favor of #14
from initials.
A great idea @gr2m :)
from initials.
Related Issues (20)
- An in-range update of tape is breaking the build 🚨 HOT 1
- An in-range update of semantic-release is breaking the build 🚨 HOT 2
- An in-range update of semantic-release is breaking the build 🚨 HOT 2
- An in-range update of semantic-release is breaking the build 🚨 HOT 1
- LICENSE file HOT 4
- Limit to two characters? HOT 11
- An in-range update of browserify is breaking the build 🚨 HOT 2
- An in-range update of semantic-release is breaking the build 🚨 HOT 1
- An in-range update of rimraf is breaking the build 🚨 HOT 1
- An in-range update of semantic-release is breaking the build 🚨 HOT 1
- An in-range update of semantic-release is breaking the build 🚨 HOT 3
- An in-range update of tape is breaking the build 🚨 HOT 1
- An in-range update of semantic-release is breaking the build 🚨 HOT 1
- An in-range update of tape is breaking the build 🚨 HOT 1
- An in-range update of tape is breaking the build 🚨 HOT 1
- An in-range update of semantic-release is breaking the build 🚨 HOT 1
- Typescript support HOT 4
- Type Definition Error TS2309 HOT 1
- More intelligent TypeScript return type HOT 3
- The automated release is failing 🚨 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from initials.