Git Product home page Git Product logo

Comments (5)

zoepage avatar zoepage commented on September 3, 2024

@gr2m could you verify this or is this "a feature"? :)

from initials.

gr2m avatar gr2m commented on September 3, 2024

Good catch! Yes, this is a bug!

initials([['Moe Minutes', 'Moe Min'])
// returns ["MMi", "MMi"]
// should return sth like ["MoM", "MMi"]

I think this is rather an edge case, so it's not a top priority to fix, but something nice for the backlog.

from initials.

zoepage avatar zoepage commented on September 3, 2024

It breaks here:https://github.com/gr2m/initials/blob/gh-pages/initials.js#L176
splice changes the array dynamically in the for-loop.

possible solution:
possibleInitials[i] = undefined and possibleInitials = possibleInitials.filter(Boolean)
breaks 13 tests.

from initials.

gr2m avatar gr2m commented on September 3, 2024

closing in favor of #14

from initials.

zoepage avatar zoepage commented on September 3, 2024

A great idea @gr2m :)

from initials.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.