Error when parsing SDL schema about gql HOT 15 CLOSED

And another problem when parsing the GitHub schema:

Bad state: No element
dart:isolate  _RawReceivePortImpl._handleMessage

Not a significant stacktrace, though :(

from gql.

@comigor, it should be type Area implements Node & Entity

https://spec.graphql.org/June2018/#sec-Objects

from gql.

@comigor, I was able to parse the official github schema just fine. Would you be able to narrow your SDL to the part which actually fails?

from gql.

It's line 813.
https://gist.github.com/comigor/5be2f6172e70aa118d99f86f272022a8#file-github-schema-graphql-L810-L814

from gql.

Oh, you're absolutely right about the spec, though some tools that convert Introspection queries to SDL seem to generate the SDL with commas.

Do you know if the spec was different before 2018? If it used a comma before, shouldn't we be retro-compatible and parse it as well?

Reference of code used in the conversion: https://gist.github.com/stubailo/041999ba5b8b15cede60b93ff9a38f53#file-introspection-result-to-sdl-js

from gql.

The GitHub SDL I'm using was also converted from Introspection query, so I think it may be the same (or a similar) problem.

from gql.

A quick search over older versions of the spec (https://spec.graphql.org/) does not reveal any useful info about commas as separators for interfaces.

Comma is actually an ignored token in GraphQL. https://spec.graphql.org/June2018/#sec-Appendix-Grammar-Summary.Ignored-Tokens

It's weird because the snippet you gave uses the reference implementation which uses & as a separator. https://github.com/graphql/graphql-js/blob/af480089b5fcaa961adb356ef1dca13cf475e75f/src/utilities/printSchema.js#L192

from gql.

Wow that's weird! Apparently I've used a legacy version of this library (of 2 years ago): https://github.com/graphql/graphql-js/blame/652c0323ea2265fd1d001a9ee36fe9232369b75f/src/utilities/schemaPrinter.js#L179

from gql.

So probably GitHub wasn't working due to another spec difference.

from gql.

Yes, the GitHub example had a multi-line comment badly printed, probably.

from gql.

Actually, I'm still not able to parse the GitHub schema from the official source: https://github.com/octokit/graphql-schema

from gql.

That's interesting. You may notice I added a github example borrowed from package:graphql to this repo. It uses the same schema file you are pointing to (the*.graphql one; not *.json transformed).

I had some issues at the build layer, but the parser itself worked just fine without adjustment.

from gql.

I'm now trying to parse the official SDL schema (without conversion) from octokit repos without success.

from gql.

What version of package:gql are you using?
What's the error message and/or stacktrace you get?

from gql.

Artemis is now parsing AST schemas directly (and the examples have proper conversions)

from gql.