Generating tristate_optionals generates invalid code with mixed up imports about ferry HOT 10 OPEN

Ok, I think I found a solution with the use typeOverrides map, but I need to check it. I will back to you

from ferry.

Do you also have multiple operations in the same file in your larger project?

from ferry.

Yes, I group related queries and mutations for the same objects in a single file.

from ferry.

Thanks! can you reproduce this issue when you put all operations in a separate file?

from ferry.

No, code is fine when I put the mutation in a separate graphql file.

I tested different variations of putting operations in single files, grouping them slightly, etc. and stumbled on this:

If I put both operations in the same file like this, I get the wrong imports prefixes:

query Pokemons {
    pokemons {
        id
        name
    }
}

mutation UpdatePokemon($id: ID!, $name: String) {
    updatePokemon(id: $id, name: $name) {
        id
        name
    }
}

If I switch them around and rerun build_runner, I get no errors in the generated files:

mutation UpdatePokemon($id: ID!, $name: String) {
    updatePokemon(id: $id, name: $name) {
        id
        name
    }
}

query Pokemons {
    pokemons {
        id
        name
    }
}

So I don't think it's related to grouping them or spreading them into separate files.

from ferry.

The first problem is here:

because of that typeDefNode is always null and then isBuilder is true and it uses replace instead of the value assignment operator (=).

And even if originalSymbolName would be fine, in the case of CustomDate it still won't work, because the name of the Node is Date (so the name of the Scalar, not the custom class we've created)

Unfortunately, I cannot find any simple way to overcome it for now 🤔
@knaeckeKami any tips?

from ferry.

Hm I am a little bit blocked.
I think the problem is that during generating schema.schema.gql.dart file it uses 2 different allocators for input classes and input serializer classes.
I also think that the error is inside ferry_generator package, because generating the code with the use of clean gql_builder works fine and it only breaks when using ferry_generator.
But unfortunately, I am not so familiar with that code and cannot spot the error 🤔

from ferry.

Ok, no worries, I'll take a look at it.
I also think it's related to the Allocators.

from ferry.

I think I found it 😃 I can create PR soon 👌

from ferry.

Here is the fix #583 for the aforementioned issue (Test fails 😞 )
and another fix is here gql-dart/gql#448

from ferry.